From d40682a99e78c9b1145f55db24de60162db99d3c Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 5 Sep 2024 13:58:15 -0700 Subject: [PATCH] fix tests --- packages/playwright-core/src/server/bidi/bidiBrowserType.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/bidi/bidiBrowserType.ts b/packages/playwright-core/src/server/bidi/bidiBrowserType.ts index f4bacf55c7..841beb71ad 100644 --- a/packages/playwright-core/src/server/bidi/bidiBrowserType.ts +++ b/packages/playwright-core/src/server/bidi/bidiBrowserType.ts @@ -28,7 +28,6 @@ import type * as types from '../types'; import { BidiBrowser } from './bidiBrowser'; import { kBrowserCloseMessageId } from './bidiConnection'; import { chromiumSwitches } from '../chromium/chromiumSwitches'; -import { connectBidiOverCdp } from './bidiOverCdp'; export class BidiBrowserType extends BrowserType { constructor(parent: SdkObject) { @@ -39,7 +38,9 @@ export class BidiBrowserType extends BrowserType { override async connectToTransport(transport: ConnectionTransport, options: BrowserOptions): Promise { if (options.channel?.includes('chrome')) { // Chrome doesn't support Bidi, we create Bidi over CDP which is used by Chrome driver. - const bidiTransport = await connectBidiOverCdp(transport); + // bidiOverCdp depends on chromium-bidi which we only have in devDependencies, so + // we load bidiOverCdp dynamically. + const bidiTransport = await require('./bidiOverCdp').connectBidiOverCdp(transport); (transport as any)[kBidiOverCdpWrapper] = bidiTransport; transport = bidiTransport; }