Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse source 
Signed-off-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Max Schmitt 2024-06-10 11:27:21 +02:00 committed by GitHub
parent ffbcc29470
commit d4d71dda0d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright/src/common/config.ts
View file

@ -107,7 +107,7 @@ export class FullConfigInternal {
const cpus = os.cpus().length; const cpus = os.cpus().length;
this.config.workers = Math.max(1, Math.floor(cpus * (parseInt(workers, 10) / 100))); this.config.workers = Math.max(1, Math.floor(cpus * (parseInt(workers, 10) / 100)));
} else { } else {
this.config.workers = resolveWorkers(workers); this.config.workers = parseWorkers(workers);
} }
} else { } else {
this.config.workers = workers; this.config.workers = workers;
@ -223,7 +223,7 @@ function resolveReporters(reporters: Config['reporter'], rootDir: string): Repor
}); });
} }
function resolveWorkers(workers: string) { function parseWorkers(workers: string) {
const parsedWorkers = parseInt(workers, 10); const parsedWorkers = parseInt(workers, 10);
if (isNaN(parsedWorkers)) if (isNaN(parsedWorkers))
throw new Error(`Workers ${workers} must be a number or percentage.`); throw new Error(`Workers ${workers} must be a number or percentage.`);