Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: fix cookie tests on WebKit (#2359)

Browse source 
WebKit does not allow third party cookies.
This commit is contained in:
Dmitry Gozman 2020-05-26 10:22:53 -07:00 committed by GitHub
parent 43eed027bd
commit d532cd5d9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/defaultbrowsercontext.spec.js
View file

@ -111,9 +111,9 @@ describe('launchPersistentContext()', function() {
document.cookie = 'username=John Doe'; document.cookie = 'username=John Doe';
return document.cookie; return document.cookie;
}); });
expect(documentCookie).toBe('username=John Doe');
await page.waitForTimeout(2000); await page.waitForTimeout(2000);
const allowsThirdParty = CHROMIUM || FFOX; const allowsThirdParty = CHROMIUM || FFOX;
expect(documentCookie).toBe(allowsThirdParty ? 'username=John Doe' : '');
const cookies = await context.cookies(server.CROSS_PROCESS_PREFIX + '/grid.html'); const cookies = await context.cookies(server.CROSS_PROCESS_PREFIX + '/grid.html');
if (allowsThirdParty) { if (allowsThirdParty) {
expect(cookies).toEqual([ expect(cookies).toEqual([

2
test/headful.spec.js
View file

@ -96,9 +96,9 @@ describe('Headful', function() {
document.cookie = 'username=John Doe'; document.cookie = 'username=John Doe';
return document.cookie; return document.cookie;
}); });
expect(documentCookie).toBe('username=John Doe');
await page.waitForTimeout(2000); await page.waitForTimeout(2000);
const allowsThirdParty = CHROMIUM || FFOX; const allowsThirdParty = CHROMIUM || FFOX;
expect(documentCookie).toBe(allowsThirdParty ? 'username=John Doe' : '');
const cookies = await page.context().cookies(server.CROSS_PROCESS_PREFIX + '/grid.html'); const cookies = await page.context().cookies(server.CROSS_PROCESS_PREFIX + '/grid.html');
if (allowsThirdParty) { if (allowsThirdParty) {
expect(cookies).toEqual([ expect(cookies).toEqual([