From d615fd3d667ed26865ec4e5c2698cb3783999c94 Mon Sep 17 00:00:00 2001
From: Simon Knott <info@simonknott.de>
Date: Thu, 23 Jan 2025 15:18:46 +0100
Subject: [PATCH] more

---
 docs/src/api/class-mockingproxyfactory.md           | 2 +-
 packages/playwright-core/src/server/mockingProxy.ts | 8 ++++++++
 packages/playwright-core/src/server/network.ts      | 8 ++++----
 packages/playwright-core/types/types.d.ts           | 2 +-
 4 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/docs/src/api/class-mockingproxyfactory.md b/docs/src/api/class-mockingproxyfactory.md
index 88e868c7d0..16fbe16951 100644
--- a/docs/src/api/class-mockingproxyfactory.md
+++ b/docs/src/api/class-mockingproxyfactory.md
@@ -13,6 +13,6 @@ Creates a new instance of [MockingProxy].
 
 ### param: MockingProxyFactory.newProxy.port
 * since: v1.51
-- `port` <[int]>
+- `port` ?<[int]>
 
 Port to listen on.
diff --git a/packages/playwright-core/src/server/mockingProxy.ts b/packages/playwright-core/src/server/mockingProxy.ts
index c7a951aa11..402bfd38ec 100644
--- a/packages/playwright-core/src/server/mockingProxy.ts
+++ b/packages/playwright-core/src/server/mockingProxy.ts
@@ -198,6 +198,14 @@ export class MockingProxy extends SdkObject implements RequestContext {
     else
       await route.continue({ isFallback: false });
   }
+
+  addRouteInFlight(route: Route): void {
+    // no-op, might be useful for warnings
+  }
+
+  removeRouteInFlight(route: Route): void {
+    // no-op, might be useful for warnings
+  }
 }
 
 function headersArray(req: Pick<http.IncomingMessage, 'headersDistinct'>): HeadersArray {
diff --git a/packages/playwright-core/src/server/network.ts b/packages/playwright-core/src/server/network.ts
index b4f5020093..ae74e7358d 100644
--- a/packages/playwright-core/src/server/network.ts
+++ b/packages/playwright-core/src/server/network.ts
@@ -91,8 +91,8 @@ export function stripFragmentFromUrl(url: string): string {
 export interface RequestContext extends SdkObject {
   fetchRequest: APIRequestContext;
 
-  addRouteInFlight?(route: Route): void;
-  removeRouteInFlight?(route: Route): void;
+  addRouteInFlight(route: Route): void;
+  removeRouteInFlight(route: Route): void;
 }
 
 export class Request extends SdkObject {
@@ -261,7 +261,7 @@ export class Route extends SdkObject {
     super(request._frame || request._context, 'route');
     this._request = request;
     this._delegate = delegate;
-    this._request._context.addRouteInFlight?.(this);
+    this._request._context.addRouteInFlight(this);
   }
 
   request(): Request {
@@ -347,7 +347,7 @@ export class Route extends SdkObject {
   }
 
   private _endHandling() {
-    this._request._context.removeRouteInFlight?.(this);
+    this._request._context.removeRouteInFlight(this);
   }
 }
 
diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts
index fb3bceae96..99354d3760 100644
--- a/packages/playwright-core/types/types.d.ts
+++ b/packages/playwright-core/types/types.d.ts
@@ -20379,7 +20379,7 @@ export interface MockingProxyFactory {
    * Creates a new instance of [MockingProxy](https://playwright.dev/docs/api/class-mockingproxy).
    * @param port Port to listen on.
    */
-  newProxy(port: number): Promise<MockingProxy>;
+  newProxy(port?: number): Promise<MockingProxy>;
 }
 
 /**