Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: update expectation on windows for "should reject if launched br… (#27603)

Browse source 
…owser fails immediately"

The test has been failing on Windows since
f212fd1a83
This commit is contained in:
Yury Semikhatsky 2023-10-13 14:02:55 -07:00 committed by GitHub
parent 6400e5c564
commit d6adfee7c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/library/browsertype-launch.spec.ts
View file

@ -59,12 +59,12 @@ it('should throw if page argument is passed', async ({ browserType, browserName
expect(waitError.message).toContain('can not specify page'); expect(waitError.message).toContain('can not specify page');
}); });
it('should reject if launched browser fails immediately', async ({ mode, browserType, asset }) => { it('should reject if launched browser fails immediately', async ({ mode, browserType, asset, isWindows }) => {
it.skip(mode.startsWith('service')); it.skip(mode.startsWith('service'));
let waitError = null; let waitError = null;
await browserType.launch({ executablePath: asset('dummy_bad_browser_executable.js') }).catch(e => waitError = e); await browserType.launch({ executablePath: asset('dummy_bad_browser_executable.js') }).catch(e => waitError = e);
expect(waitError.message).toContain('Browser logs:'); expect(waitError.message).toContain(isWindows ? 'browserType.launch: spawn UNKNOWN' : 'Browser logs:');
}); });
it('should reject if executable path is invalid', async ({ browserType, mode }) => { it('should reject if executable path is invalid', async ({ browserType, mode }) => {