From d786a27ed5d18fd7f617ae7ec1f5ee08705c1ce8 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 9 Aug 2024 11:55:22 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Yury Semikhatsky Signed-off-by: Simon Knott --- docs/src/best-practices-js.md | 2 +- docs/src/ci.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/src/best-practices-js.md b/docs/src/best-practices-js.md index 15b4ffc993..7d4830b6cb 100644 --- a/docs/src/best-practices-js.md +++ b/docs/src/best-practices-js.md @@ -261,7 +261,7 @@ npx playwright --version Setup CI/CD and run your tests frequently. The more often you run your tests the better. Ideally you should run your tests on each commit and pull request. Playwright comes with a [GitHub actions workflow](/ci-intro.md) so that tests will run on CI for you with no setup required. Playwright can also be setup on the [CI environment](/ci.md) of your choice. -Use Linux when running your tests on CI as it is cheaper. Developers can use whatever environment when running locally but use linux on CI. Set up [Sharding](./test-sharding.md) to make CI faster. +Use Linux when running your tests on CI as it is cheaper. Developers can use whatever environment when running locally but use linux on CI. Consider setting up [Sharding](./test-sharding.md) to make CI faster. ### Lint your tests diff --git a/docs/src/ci.md b/docs/src/ci.md index 2c8196f1bb..e72ce215d6 100644 --- a/docs/src/ci.md +++ b/docs/src/ci.md @@ -61,9 +61,9 @@ export default defineConfig({ ## CI configurations -### GitHub Actions +The [Command line tools](./browsers#install-system-dependencies) can be used to install all operating system dependencies in CI. -The [Command line tools](./browsers#install-system-dependencies) can be used to install all operating system dependencies on GitHub Actions. +### GitHub Actions #### On push/pull_request * langs: js