From d7901ea9ff719fa43fcae61c0e6264f968079c7c Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 22 Sep 2021 17:09:09 -0700 Subject: [PATCH] test: unflake inspector/pause.spec.ts (#9096) --- tests/inspector/pause.spec.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/inspector/pause.spec.ts b/tests/inspector/pause.spec.ts index 4fda959411..ad72ca834a 100644 --- a/tests/inspector/pause.spec.ts +++ b/tests/inspector/pause.spec.ts @@ -238,22 +238,22 @@ it.describe('pause', () => { const scriptPromise = (async () => { await page.pause(); await Promise.all([ - page.waitForEvent('console', { timeout: 1 }), - page.click('button'), + page.waitForEvent('console', { timeout: 1 }).catch(() => {}), + page.pause(), ]); - })().catch(() => {}); + })(); const recorderPage = await recorderPageGetter(); await recorderPage.click('[title="Step over"]'); - await recorderPage.waitForSelector('.source-line-paused:has-text("page.click")'); + await recorderPage.waitForSelector('.source-line-paused:has-text("page.pause")'); await recorderPage.waitForSelector('.source-line-error:has-text("page.waitForEvent")'); - await recorderPage.click('[title="Resume"]'); expect(await sanitizeLog(recorderPage)).toEqual([ 'page.pause- XXms', 'page.waitForEvent(console)', 'waiting for event \"console\"', 'error: Timeout while waiting for event \"console\"', - 'page.click(button)- XXms', + 'page.pause', ]); + await recorderPage.click('[title="Resume"]'); await scriptPromise; }); @@ -277,7 +277,8 @@ it.describe('pause', () => { const recorderPage = await recorderPageGetter(); await recorderPage.click('[title="Step over"]'); await recorderPage.waitForSelector('.source-line-paused:has-text("page.context().close();")'); - await recorderPage.click('[title=Resume]'); + // Next line can throw because closing context also closes the inspector page. + await recorderPage.click('[title=Resume]').catch(e => {}); await scriptPromise; });