Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: enable localhost proxy tests on webkit mac, unless bypass rules are set (#29641)

Browse source
This commit is contained in:
Dmitry Gozman 2024-02-23 14:27:30 -08:00 committed by GitHub
parent 4d868f6ba8
commit d7c4ee901a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/library/browsercontext-proxy.spec.ts
View file

@ -132,14 +132,14 @@ it.describe('should proxy local network requests', () => {
} }
]) { ]) {
it(`${params.description}`, async ({ platform, browserName, contextFactory, server, proxyServer }) => { it(`${params.description}`, async ({ platform, browserName, contextFactory, server, proxyServer }) => {
it.skip(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target), 'Mac webkit does not proxy localhost'); it.skip(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target) && additionalBypass, 'Mac webkit does not proxy localhost when bypass rules are set');
const path = `/target-${additionalBypass}-${params.target}.html`; const path = `/target-${additionalBypass}-${params.target}.html`;
server.setRoute(path, async (req, res) => { server.setRoute(path, async (req, res) => {
res.end('<html><title>Served by the proxy</title></html>'); res.end('<html><title>Served by the proxy</title></html>');
}); });
const url = `http://${params.target}:${server.PORT}${path}`; const url = `http://${params.target}:55555${path}`;
proxyServer.forwardTo(server.PORT); proxyServer.forwardTo(server.PORT);
const context = await contextFactory({ const context = await contextFactory({
proxy: { server: `localhost:${proxyServer.PORT}`, bypass: additionalBypass ? '1.non.existent.domain.for.the.test' : undefined } proxy: { server: `localhost:${proxyServer.PORT}`, bypass: additionalBypass ? '1.non.existent.domain.for.the.test' : undefined }

4
tests/library/proxy.spec.ts
View file

@ -91,14 +91,14 @@ it.describe('should proxy local network requests', () => {
} }
]) { ]) {
it(`${params.description}`, async ({ platform, browserName, browserType, server, proxyServer }) => { it(`${params.description}`, async ({ platform, browserName, browserType, server, proxyServer }) => {
it.skip(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target), 'Mac webkit does not proxy localhost.'); it.skip(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target) && additionalBypass, 'Mac webkit does not proxy localhost when bypass rules are set.');
const path = `/target-${additionalBypass}-${params.target}.html`; const path = `/target-${additionalBypass}-${params.target}.html`;
server.setRoute(path, async (req, res) => { server.setRoute(path, async (req, res) => {
res.end('<html><title>Served by the proxy</title></html>'); res.end('<html><title>Served by the proxy</title></html>');
}); });
const url = `http://${params.target}:${server.PORT}${path}`; const url = `http://${params.target}:55555${path}`;
proxyServer.forwardTo(server.PORT); proxyServer.forwardTo(server.PORT);
const browser = await browserType.launch({ const browser = await browserType.launch({
proxy: { server: `localhost:${proxyServer.PORT}`, bypass: additionalBypass ? '1.non.existent.domain.for.the.test' : undefined } proxy: { server: `localhost:${proxyServer.PORT}`, bypass: additionalBypass ? '1.non.existent.domain.for.the.test' : undefined }