Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

docs: remove the create method from extensibility (#28823)

Browse source 
I saw the `create` method in the
[Extensibility](https://playwright.dev/docs/extensibility) section of
the document but didn't quite understand its actual purpose. Therefore,
I attempted to add this method in the test examples, but it seems that
regardless of what this method returns or if it throws an error, it has
no effect. Upon further examination of the
[selectors.ts](https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/client/selectors.ts)
and
[types.ts](https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/client/types.ts#L129)
files, I noticed that this method is not defined. Consequently, I opened
this pull request to remove the description of this method to prevent
any potential misunderstandings by others.

If there are any misunderstandings, feel free to close this pull
request. Thank you.
This commit is contained in:
Xuan 2024-01-04 01:39:57 +08:00 committed by GitHub
parent 620c82af48
commit d8733d9229
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/extensibility.md
View file

@ -7,8 +7,6 @@ title: "Extensibility"
Playwright supports custom selector engines, registered with [`method: Selectors.register`].
Selector engine should have the following properties:
- `create` function to create a relative selector from `root` (root is either a `Document`, `ShadowRoot` or `Element`)
to a `target` element.
- `query` function to query first element matching `selector` relative to the `root`.
- `queryAll` function to query all elements matching `selector` relative to the `root`.