From d8d044e5edf36f85951c51ae86b462a7ba748105 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 18 Oct 2024 11:00:33 +0200 Subject: [PATCH] Revert "don't swallow the first error if the second throws" This reverts commit 13a4d1976457a3c3fcb9c3d7f0d078a72b0fc8a1. --- packages/playwright/src/runner/tasks.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/playwright/src/runner/tasks.ts b/packages/playwright/src/runner/tasks.ts index aeeafe7b41..aeaceadc8b 100644 --- a/packages/playwright/src/runner/tasks.ts +++ b/packages/playwright/src/runner/tasks.ts @@ -182,18 +182,15 @@ function createGlobalSetupTask(index: number, length: number): Task { globalSetupFinished = true; }, teardown: async ({ config }) => { - const errors = []; + let firstError: any; if (typeof globalSetupResult === 'function') - try { await globalSetupResult(); } catch (error) { errors.push(error); } + try { await globalSetupResult(); } catch (error) { firstError = error; } if (globalSetupFinished) - try { await teardownHook?.(config.config); } catch (error) { errors.push(error); } + await teardownHook?.(config.config); - if (errors.length === 1) - throw errors[0]; - - if (errors.length > 1) - throw new AggregateError(errors); + if (firstError) + throw firstError; }, }; }