Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: strip off hash from request urls (#297)

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-18 17:27:20 -07:00 committed by Andrey Lushnikov
parent b5e9086576
commit da051a72a8
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/network.ts
View file

@ -67,6 +67,15 @@ export function rewriteCookies(cookies: SetNetworkCookieParam[]): SetNetworkCook
}); });
} }
function stripFragmentFromUrl(url: string): string
{
if (!url.indexOf('#'))
return url;
const parsed = new URL(url);
parsed.hash = '';
return parsed.href;
}
export type Headers = { [key: string]: string }; export type Headers = { [key: string]: string };
export class Request { export class Request {
@ -94,7 +103,7 @@ export class Request {
for (const request of redirectChain) for (const request of redirectChain)
request._finalRequest = this; request._finalRequest = this;
this._documentId = documentId; this._documentId = documentId;
this._url = url; this._url = stripFragmentFromUrl(url);
this._resourceType = resourceType; this._resourceType = resourceType;
this._method = method; this._method = method;
this._postData = postData; this._postData = postData;

2
test/navigation.spec.js
View file

@ -390,7 +390,7 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
expect(requests.length).toBe(1); expect(requests.length).toBe(1);
expect(requests[0].url()).toBe(dataURL); expect(requests[0].url()).toBe(dataURL);
}); });
it.skip(FFOX || WEBKIT)('should navigate to URL with hash and fire requests without hash', async({page, server}) => { it('should navigate to URL with hash and fire requests without hash', async({page, server}) => {
const requests = []; const requests = [];
page.on('request', request => !utils.isFavicon(request) && requests.push(request)); page.on('request', request => !utils.isFavicon(request) && requests.push(request));
const response = await page.goto(server.EMPTY_PAGE + '#hash'); const response = await page.goto(server.EMPTY_PAGE + '#hash');