Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: disable network sizes tests on old electron (#15252)

Browse source
This commit is contained in:
Dmitry Gozman 2022-06-29 17:50:42 -07:00 committed by GitHub
parent a5ddf560e9
commit da9d68265b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/page/page-network-request.spec.ts
View file

@ -81,7 +81,8 @@ it('should return headers', async ({ page, server, browserName }) => {
expect(response.request().headers()['user-agent']).toContain('WebKit');
});
it('should get the same headers as the server', async ({ page, server, browserName, platform }) => {
it('should get the same headers as the server', async ({ page, server, browserName, platform, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
it.fail(browserName === 'webkit' && platform === 'win32', 'Curl does not show accept-encoding and accept-language');
let serverRequest;
server.setRoute('/empty.html', (request, response) => {
@ -93,7 +94,8 @@ it('should get the same headers as the server', async ({ page, server, browserNa
expect(headers).toEqual(serverRequest.headers);
});
it('should not return allHeaders() until they are available', async ({ page, server, browserName, platform }) => {
it('should not return allHeaders() until they are available', async ({ page, server, browserName, platform, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
it.fail(browserName === 'webkit' && platform === 'win32', 'Curl does not show accept-encoding and accept-language');
let requestHeadersPromise;
@ -117,7 +119,8 @@ it('should not return allHeaders() until they are available', async ({ page, ser
expect(responseHeaders['foo']).toBe('bar');
});
it('should get the same headers as the server CORS', async ({ page, server, browserName, platform }) => {
it('should get the same headers as the server CORS', async ({ page, server, browserName, platform, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
it.fail(browserName === 'webkit' && platform === 'win32', 'Curl does not show accept-encoding and accept-language');
await page.goto(server.PREFIX + '/empty.html');
@ -349,7 +352,9 @@ it('should return navigation bit when navigating to image', async ({ page, serve
expect(requests[0].isNavigationRequest()).toBe(true);
});
it('should report raw headers', async ({ page, server, browserName, platform }) => {
it('should report raw headers', async ({ page, server, browserName, platform, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
let expectedHeaders: { name: string, value: string }[];
server.setRoute('/headers', (req, res) => {
expectedHeaders = [];
@ -415,7 +420,9 @@ it('should report raw response headers in redirects', async ({ page, server, bro
expect(headersChain).toEqual(expectedHeaders);
});
it('should report all cookies in one header', async ({ page, server }) => {
it('should report all cookies in one header', async ({ page, server, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
const expectedHeaders = {};
server.setRoute('/headers', (req, res) => {
for (let i = 0; i < req.rawHeaders.length; i += 2)

8
tests/page/page-network-response.spec.ts
View file

@ -179,8 +179,10 @@ it('should return status text', async ({ page, server }) => {
expect(response.statusText()).toBe('cool!');
});
it('should report all headers', async ({ page, server, browserName, platform }) => {
it('should report all headers', async ({ page, server, browserName, platform, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
it.fixme(browserName === 'webkit' && platform === 'win32', 'libcurl does not support non-set-cookie multivalue headers');
const expectedHeaders = {
'header-a': ['value-a', 'value-a-1', 'value-a-2'],
'header-b': ['value-b'],
@ -213,7 +215,9 @@ it('should report all headers', async ({ page, server, browserName, platform })
expect(actualHeaders).toEqual(expectedHeaders);
});
it('should report multiple set-cookie headers', async ({ page, server }) => {
it('should report multiple set-cookie headers', async ({ page, server, isElectron, browserMajorVersion }) => {
it.skip(isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
server.setRoute('/headers', (req, res) => {
res.writeHead(200, {
'Set-Cookie': ['a=b', 'c=d']

2
tests/page/page-network-sizes.spec.ts
View file

@ -20,6 +20,8 @@ import zlib from 'zlib';
import { test as it, expect } from './pageTest';
it.skip(({ isElectron, browserMajorVersion }) => isElectron && browserMajorVersion < 17, 'This needs Chromium >= 99');
it('should set bodySize and headersSize', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
const [request] = await Promise.all([