From db93e9766e9f6d2f904ec748950463da83b0360e Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Mon, 14 Nov 2022 13:58:13 -0800 Subject: [PATCH] =?UTF-8?q?cherry-pick(#18791):=20Revert=20"chore(driver):?= =?UTF-8?q?=20roll=20driver=20to=20recent=20Nod=E2=80=A6=20(#18794)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …e.js LTS version (#18636)" The new node resolves loalhost to ::1 by default which breaks API tests in the ports (Java in particular). Reverting to the previous LTS to allow some time to implement happy eyeballs algorithm on our end by next release. This reverts commit 63a0b75186c984528dc661c6d334bb0fb6a7002a. Reference https://github.com/microsoft/playwright/issues/18790 --- utils/build/build-playwright-driver.sh | 2 +- utils/docker/Dockerfile.focal | 4 ++-- utils/docker/Dockerfile.jammy | 4 ++-- utils/linux-browser-dependencies/inside_docker/process.sh | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/utils/build/build-playwright-driver.sh b/utils/build/build-playwright-driver.sh index b477ead7f9..b50c6dd248 100755 --- a/utils/build/build-playwright-driver.sh +++ b/utils/build/build-playwright-driver.sh @@ -4,7 +4,7 @@ set -x trap "cd $(pwd -P)" EXIT SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)" -NODE_VERSION="18.12.1" # autogenerated via ./update-playwright-driver-version.mjs +NODE_VERSION="16.18.0" # autogenerated via ./update-playwright-driver-version.mjs cd "$(dirname "$0")" PACKAGE_VERSION=$(node -p "require('../../package.json').version") diff --git a/utils/docker/Dockerfile.focal b/utils/docker/Dockerfile.focal index 6eebb33f16..f6db13a34a 100644 --- a/utils/docker/Dockerfile.focal +++ b/utils/docker/Dockerfile.focal @@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-focal" # === INSTALL Node.js === RUN apt-get update && \ - # Install node18 + # Install node16 apt-get install -y curl wget gpg && \ - curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ + curl -sL https://deb.nodesource.com/setup_16.x | bash - && \ apt-get install -y nodejs && \ # Feature-parity with node.js base images. apt-get install -y --no-install-recommends git openssh-client && \ diff --git a/utils/docker/Dockerfile.jammy b/utils/docker/Dockerfile.jammy index 908c671e74..63868afbdd 100644 --- a/utils/docker/Dockerfile.jammy +++ b/utils/docker/Dockerfile.jammy @@ -7,9 +7,9 @@ ARG DOCKER_IMAGE_NAME_TEMPLATE="mcr.microsoft.com/playwright:v%version%-jammy" # === INSTALL Node.js === RUN apt-get update && \ - # Install node18 + # Install node16 apt-get install -y curl wget gpg && \ - curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ + curl -sL https://deb.nodesource.com/setup_16.x | bash - && \ apt-get install -y nodejs && \ # Feature-parity with node.js base images. apt-get install -y --no-install-recommends git openssh-client && \ diff --git a/utils/linux-browser-dependencies/inside_docker/process.sh b/utils/linux-browser-dependencies/inside_docker/process.sh index 2fa85035c5..be813f52e0 100755 --- a/utils/linux-browser-dependencies/inside_docker/process.sh +++ b/utils/linux-browser-dependencies/inside_docker/process.sh @@ -5,7 +5,7 @@ set +x # Install Node.js apt-get update && apt-get install -y curl && \ - curl -sL https://deb.nodesource.com/setup_18.x | bash - && \ + curl -sL https://deb.nodesource.com/setup_16.x | bash - && \ apt-get install -y nodejs # Install apt-file