diff --git a/docs/src/browsers.md b/docs/src/browsers.md index 1cc10d7a8d..4b13b35c4c 100644 --- a/docs/src/browsers.md +++ b/docs/src/browsers.md @@ -452,7 +452,7 @@ Certain Enterprise Browser Policies may impact Playwright's ability to launch an ::: :::warning -Google Chrome and Microsoft Edge have switched to a [new headless mode](https://developer.chrome.com/docs/chromium/headless) implementation that is closer to a regular headed mode. This differs from [chromium headless shell](https://developer.chrome.com/blog/chrome-headless-shell) that is used in Playwright by default when running headless, so expect different behavior in some cases. See [issue #33566](https://github.com/microsoft/playwright/issues/33566) fore details. +Google Chrome and Microsoft Edge have switched to a [new headless mode](https://developer.chrome.com/docs/chromium/headless) implementation that is closer to a regular headed mode. This differs from [chromium headless shell](https://developer.chrome.com/blog/chrome-headless-shell) that is used in Playwright by default when running headless, so expect different behavior in some cases. See [issue #33566](https://github.com/microsoft/playwright/issues/33566) for details. ::: ```js diff --git a/packages/html-reporter/src/links.css b/packages/html-reporter/src/links.css index 4abe8a6caa..eb9390844b 100644 --- a/packages/html-reporter/src/links.css +++ b/packages/html-reporter/src/links.css @@ -60,6 +60,11 @@ color: var(--color-scale-orange-6); border: 1px solid var(--color-scale-orange-4); } + .label-color-gray { + background-color: var(--color-scale-gray-0); + color: var(--color-scale-gray-6); + border: 1px solid var(--color-scale-gray-4); + } } @media(prefers-color-scheme: dark) { @@ -93,6 +98,11 @@ color: var(--color-scale-orange-2); border: 1px solid var(--color-scale-orange-4); } + .label-color-gray { + background-color: var(--color-scale-gray-9); + color: var(--color-scale-gray-2); + border: 1px solid var(--color-scale-gray-4); + } } .attachment-body { diff --git a/packages/html-reporter/src/testResultView.tsx b/packages/html-reporter/src/testResultView.tsx index 9dcdf29092..4c504a0118 100644 --- a/packages/html-reporter/src/testResultView.tsx +++ b/packages/html-reporter/src/testResultView.tsx @@ -134,7 +134,7 @@ export const TestResultView: React.FC<{ )} } - {!!otherAttachments.size && + {!!otherAttachments.size && {[...otherAttachments].map((a, i) => @@ -176,15 +176,27 @@ const StepTreeItem: React.FC<{ }> = ({ test, step, result, depth }) => { return {msToString(step.duration)} - {step.attachments.length > 0 && { evt.stopPropagation(); }}>{icons.attachment()}} {statusIcon(step.error || step.duration === -1 ? 'failed' : 'passed')} {step.title} {step.count > 1 && <> ✕ {step.count}} {step.location && — {step.location.file}:{step.location.line}} } loadChildren={step.steps.length + (step.snippet ? 1 : 0) ? () => { - const children = step.steps.map((s, i) => ); - if (step.snippet) - children.unshift(); - return children; + const snippet = step.snippet ? [] : []; + const steps = step.steps.map((s, i) => ); + const attachments = step.attachments.map(attachmentIndex => ( + + + {icons.attachment()}{result.attachments[attachmentIndex].name} + + + )); + return snippet.concat(steps, attachments); } : undefined} depth={depth}/>; }; diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 7a2dae891d..0803da3ff1 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -21,13 +21,13 @@ }, { "name": "firefox-beta", - "revision": "1466", + "revision": "1467", "installByDefault": false, "browserVersion": "133.0b9" }, { "name": "webkit", - "revision": "2122", + "revision": "2123", "installByDefault": true, "revisionOverrides": { "debian11-x64": "2105", diff --git a/tests/library/har.spec.ts b/tests/library/har.spec.ts index 92358608e9..88419e742c 100644 --- a/tests/library/har.spec.ts +++ b/tests/library/har.spec.ts @@ -60,7 +60,10 @@ it('should have browser', async ({ browserName, browser, contextFactory, server const { page, getLog } = await pageWithHar(contextFactory, testInfo); await page.goto(server.EMPTY_PAGE); const log = await getLog(); - expect(log.browser!.name.toLowerCase()).toBe(browserName); + + // _bidiFirefox and _bidiChromium are initialized with 'bidi' as browser name. + const harBrowserName = browserName.startsWith('_bidi') ? 'bidi' : browserName; + expect(log.browser!.name.toLowerCase()).toBe(harBrowserName); expect(log.browser!.version).toBe(browser.version()); }); @@ -957,6 +960,9 @@ it('should not hang on slow chunked response', async ({ browserName, browser, co await page.goto(server.EMPTY_PAGE); await page.evaluate(() => (window as any).receivedFirstData); const log = await getLog(); - expect(log.browser!.name.toLowerCase()).toBe(browserName); + + // _bidiFirefox and _bidiChromium are initialized with 'bidi' as browser name. + const harBrowserName = browserName.startsWith('_bidi') ? 'bidi' : browserName; + expect(log.browser!.name.toLowerCase()).toBe(harBrowserName); expect(log.browser!.version).toBe(browser.version()); }); diff --git a/tests/playwright-test/reporter-html.spec.ts b/tests/playwright-test/reporter-html.spec.ts index 7c7c60836f..f1e2bb4eda 100644 --- a/tests/playwright-test/reporter-html.spec.ts +++ b/tests/playwright-test/reporter-html.spec.ts @@ -932,9 +932,10 @@ for (const useIntermediateMergeReport of [true, false] as const) { await showReport(); await page.getByRole('link', { name: 'passing' }).click(); - const attachment = page.getByText('foo-2', { exact: true }); + const attachment = page.getByTestId('attachments').getByText('foo-2', { exact: true }); await expect(attachment).not.toBeInViewport(); - await page.getByLabel('attach "foo-2"').getByTitle('link to attachment').click(); + await page.getByLabel('attach "foo-2"').click(); + await page.getByTitle('see "foo-2"').click(); await expect(attachment).toBeInViewport(); await page.reload(); @@ -961,9 +962,10 @@ for (const useIntermediateMergeReport of [true, false] as const) { await showReport(); await page.getByRole('link', { name: 'passing' }).click(); - const attachment = page.getByText('attachment', { exact: true }); + const attachment = page.getByTestId('attachments').getByText('attachment', { exact: true }); await expect(attachment).not.toBeInViewport(); - await page.getByLabel('step').getByTitle('link to attachment').click(); + await page.getByLabel('step').click(); + await page.getByTitle('see "attachment"').click(); await expect(attachment).toBeInViewport(); });