Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

runtime checks

Browse source
This commit is contained in:
Joel Einbinder 2019-12-06 00:14:16 +00:00
parent 40b64a5b60
commit dcf92e4d2f
2 changed files with 21 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/dom.ts
View file

@ -78,7 +78,7 @@ export class DOMWorld {
const resolved = await this.resolveSelector(selector); const resolved = await this.resolveSelector(selector);
const handle = await this.context.evaluateHandle( const handle = await this.context.evaluateHandle(
(injected: Injected, selector: string, scope?: Node, visible?: boolean) => { (injected: Injected, selector: string, scope?: Node, visible?: boolean) => {
const element = injected.querySelector(selector, scope as SelectorRoot || document); const element = injected.querySelector(selector, scope || document);
if (visible === undefined || !element) if (visible === undefined || !element)
return element; return element;
return injected.isVisible(element) === visible ? element : undefined; return injected.isVisible(element) === visible ? element : undefined;
@ -96,7 +96,7 @@ export class DOMWorld {
const resolved = await this.resolveSelector(selector); const resolved = await this.resolveSelector(selector);
const arrayHandle = await this.context.evaluateHandle( const arrayHandle = await this.context.evaluateHandle(
(injected: Injected, selector: string, scope?: Node, visible?: boolean) => { (injected: Injected, selector: string, scope?: Node, visible?: boolean) => {
const elements = injected.querySelectorAll(selector, scope as SelectorRoot || document); const elements = injected.querySelectorAll(selector, scope || document);
if (visible !== undefined) if (visible !== undefined)
return elements.filter(element => injected.isVisible(element) === visible); return elements.filter(element => injected.isVisible(element) === visible);
return elements; return elements;
@ -131,7 +131,7 @@ export class DOMWorld {
const resolved = await this.resolveSelector(selector); const resolved = await this.resolveSelector(selector);
const arrayHandle = await this.context.evaluateHandle( const arrayHandle = await this.context.evaluateHandle(
(injected: Injected, selector: string, scope?: Node, visible?: boolean) => { (injected: Injected, selector: string, scope?: Node, visible?: boolean) => {
const elements = injected.querySelectorAll(selector, scope as SelectorRoot || document); const elements = injected.querySelectorAll(selector, scope || document);
if (visible !== undefined) if (visible !== undefined)
return elements.filter(element => injected.isVisible(element) === visible); return elements.filter(element => injected.isVisible(element) === visible);
return elements; return elements;
@ -246,13 +246,25 @@ export class ElementHandle<T extends Node = Node> extends js.JSHandle<T> {
} }
async setInputFiles(...files: (string|input.FilePayload)[]) { async setInputFiles(...files: (string|input.FilePayload)[]) {
const multiple = await this.evaluate((element: Node) => !!(element as HTMLInputElement).multiple); const multiple = await this.evaluate((node: Node) => {
if (node.nodeType !== Node.ELEMENT_NODE || (node as Element).tagName !== 'INPUT')
throw new Error('Node is not an HTMLInputElement');
const input = node as HTMLInputElement;
return input.multiple;
});
assert(multiple || files.length <= 1, 'Non-multiple file input can only accept single file!'); assert(multiple || files.length <= 1, 'Non-multiple file input can only accept single file!');
await this._world.delegate.setInputFiles(this, await input.loadFiles(files)); await this._world.delegate.setInputFiles(this, await input.loadFiles(files));
} }
async focus() { async focus() {
await this.evaluate((element: Node) => (element as HTMLElement).focus()); const errorMessage = await this.evaluate((element: Node) => {
if (!element['focus'])
return 'Node is not an HTML or SVG element.';
(element as HTMLElement|SVGElement).focus();
return false;
});
if (errorMessage)
throw new Error(errorMessage);
} }
async type(text: string, options: { delay: (number | undefined); } | undefined) { async type(text: string, options: { delay: (number | undefined); } | undefined) {

6
src/injected/injected.ts
View file

@ -31,9 +31,11 @@ class Injected {
return element as Element; return element as Element;
} }
querySelectorAll(selector: string, root: SelectorRoot): Element[] { querySelectorAll(selector: string, root: Node): Element[] {
const parsed = this._parseSelector(selector); const parsed = this._parseSelector(selector);
let set = new Set<SelectorRoot>([ root ]); if (!root["querySelectorAll"])
throw new Error('Node is not queryable.');
let set = new Set<SelectorRoot>([ root as SelectorRoot ]);
for (const { engine, selector } of parsed) { for (const { engine, selector } of parsed) {
const newSet = new Set<Element>(); const newSet = new Set<Element>();
for (const prev of set) { for (const prev of set) {