Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: fix browsercontext-basic offline test (#28558)

Browse source 
Since the last firefox roll, firefox now does internal redirect to the
error page when it's been forced into offline mode.
This commit is contained in:
Andrey Lushnikov 2023-12-08 15:26:24 -08:00 committed by GitHub
parent 7827838d22
commit dd9028cfe2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/library/browsercontext-basic.spec.ts
View file

@ -233,11 +233,21 @@ it('setContent should work after disabling javascript', async ({ contextFactory
await expect(page.locator('h1')).toHaveText('Hello'); await expect(page.locator('h1')).toHaveText('Hello');
}); });
it('should work with offline option', async ({ browser, server }) => { it('should work with offline option', async ({ browser, server, browserName }) => {
const context = await browser.newContext({ offline: true }); const context = await browser.newContext({ offline: true });
const page = await context.newPage(); const page = await context.newPage();
let error = null; let error = null;
await page.goto(server.EMPTY_PAGE).catch(e => error = e); if (browserName === 'firefox') {
// Firefox navigates to an error page, and this navigation might conflict with the
// next navigation we do in test.
// So we need to wait for the navigation explicitly.
await Promise.all([
page.goto(server.EMPTY_PAGE).catch(e => error = e),
page.waitForEvent('framenavigated'),
]);
} else {
await page.goto(server.EMPTY_PAGE).catch(e => error = e);
}
expect(error).toBeTruthy(); expect(error).toBeTruthy();
await context.setOffline(false); await context.setOffline(false);
const response = await page.goto(server.EMPTY_PAGE); const response = await page.goto(server.EMPTY_PAGE);