Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: friendlier install failure message (#5281)

Browse source
This commit is contained in:
Pavel Feldman 2021-02-04 06:23:47 -08:00 committed by GitHub
parent 3126fee780
commit dd9b51d68b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/cli/cli.ts
View file

@ -130,6 +130,13 @@ program
.command('install [browserType...]') .command('install [browserType...]')
.description('Ensure browsers necessary for this version of Playwright are installed') .description('Ensure browsers necessary for this version of Playwright are installed')
.action(function(browserType) { .action(function(browserType) {
const allBrowsers = new Set(['chromium', 'firefox', 'webkit']);
for (const type of browserType) {
if (!allBrowsers.has(type)) {
console.log(`Invalid browser name: '${type}'. Expecting 'chromium', 'firefox' or 'webkit'.`);
process.exit(1);
}
}
installBrowsers(browserType.length ? browserType : undefined).catch((e: any) => { installBrowsers(browserType.length ? browserType : undefined).catch((e: any) => {
console.log(`Failed to install browsers\n${e}`); console.log(`Failed to install browsers\n${e}`);
process.exit(1); process.exit(1);