Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: mark flaky proxy tests (#13050)

Browse source
This commit is contained in:
Ross Wollman 2022-03-24 14:50:59 -07:00 committed by GitHub
parent 0243bb4920
commit ddc2cd4a3e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/browsercontext-proxy.spec.ts
View file

@ -109,7 +109,7 @@ it.describe('should proxy local network requests', () => {
} }
]) { ]) {
it(`${params.description}`, async ({ platform, browserName, contextFactory, server, proxyServer }) => { it(`${params.description}`, async ({ platform, browserName, contextFactory, server, proxyServer }) => {
it.fail(browserName === 'webkit' && platform === 'darwin' && additionalBypass && ['localhost', '127.0.0.1'].includes(params.target), 'WK fails to proxy 127.0.0.1 and localhost if additional bypasses are present'); it.fixme(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target), 'Flaky on macOS; needs investigation.');
const path = `/target-${additionalBypass}-${params.target}.html`; const path = `/target-${additionalBypass}-${params.target}.html`;
server.setRoute(path, async (req, res) => { server.setRoute(path, async (req, res) => {

2
tests/proxy.spec.ts
View file

@ -91,7 +91,7 @@ it.describe('should proxy local network requests', () => {
} }
]) { ]) {
it(`${params.description}`, async ({ platform, browserName, browserType, server, proxyServer }) => { it(`${params.description}`, async ({ platform, browserName, browserType, server, proxyServer }) => {
it.fail(browserName === 'webkit' && platform === 'darwin' && additionalBypass && ['localhost', '127.0.0.1'].includes(params.target), 'WK fails to proxy 127.0.0.1 and localhost if additional bypasses are present'); it.fixme(browserName === 'webkit' && platform === 'darwin' && ['localhost', '127.0.0.1'].includes(params.target), 'Flaky on macOS; needs investigation.');
const path = `/target-${additionalBypass}-${params.target}.html`; const path = `/target-${additionalBypass}-${params.target}.html`;
server.setRoute(path, async (req, res) => { server.setRoute(path, async (req, res) => {