Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: fix headlessness reporting to flakiness dashboard (#14069)

Browse source
This commit is contained in:
Andrey Lushnikov 2022-05-10 10:03:47 -06:00 committed by GitHub
parent 4634adbdc3
commit ddcce7a63a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CONTRIBUTING.md
View file

@ -171,7 +171,7 @@ it.skip('should work', async ({server, page}) => {
- To run tests in non-headless (headed) mode: - To run tests in non-headless (headed) mode:
```bash ```bash
HEADFUL=1 npm run ctest npm run ctest -- --headed
``` ```
- To run tests with custom browser executable, specify `CRPATH`, `WKPATH` or `FFPATH` env variable that points to browser executable: - To run tests with custom browser executable, specify `CRPATH`, `WKPATH` or `FFPATH` env variable that points to browser executable:
@ -183,7 +183,7 @@ CRPATH=<path-to-executable> npm run ctest
- To run tests in slow-mode: - To run tests in slow-mode:
```bash ```bash
HEADFUL=1 SLOW_MO=500 npm run wtest SLOW_MO=500 npm run wtest -- --headed
``` ```
- When should a test be marked with `skip` or `fail`? - When should a test be marked with `skip` or `fail`?

2
tests/library/playwright.config.ts
View file

@ -36,7 +36,7 @@ const getExecutablePath = (browserName: BrowserName) => {
const mode = process.env.PW_OUT_OF_PROCESS_DRIVER ? const mode = process.env.PW_OUT_OF_PROCESS_DRIVER ?
'driver' : 'driver' :
(process.env.PWTEST_MODE || 'default') as ('default' | 'driver' | 'service' | 'service2'); (process.env.PWTEST_MODE || 'default') as ('default' | 'driver' | 'service' | 'service2');
const headed = !!process.env.HEADFUL; const headed = process.argv.includes('--headed');
const channel = process.env.PWTEST_CHANNEL as any; const channel = process.env.PWTEST_CHANNEL as any;
const video = !!process.env.PWTEST_VIDEO; const video = !!process.env.PWTEST_VIDEO;
const trace = !!process.env.PWTEST_TRACE; const trace = !!process.env.PWTEST_TRACE;