Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): do not crash when browser window is minimized (#9951)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-11-01 17:11:21 -07:00 committed by GitHub
parent 49cda3d3df
commit ddda507ccd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/firefox-beta/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1301 1302
Changed: max@schmitt.mx Mon 1 Nov 2021 16:28:05 CET Changed: yurys@chromium.org Mon 01 Nov 2021 05:04:30 PM PDT

3
browser_patches/firefox-beta/juggler/screencast/nsScreencastService.cpp
View file

@ -159,6 +159,9 @@ class nsScreencastService::Session : public rtc::VideoSinkInterface<webrtc::Vide
void OnRawFrame(uint8_t* videoFrame, size_t videoFrameStride, const webrtc::VideoCaptureCapability& frameInfo) override { void OnRawFrame(uint8_t* videoFrame, size_t videoFrameStride, const webrtc::VideoCaptureCapability& frameInfo) override {
int pageWidth = frameInfo.width - mMargin.LeftRight(); int pageWidth = frameInfo.width - mMargin.LeftRight();
int pageHeight = frameInfo.height - mMargin.TopBottom(); int pageHeight = frameInfo.height - mMargin.TopBottom();
// Frame size is 1x1 when browser window is minimized.
if (pageWidth <= 1 || pageHeight <= 1)
return;
// Headed Firefox brings sizes in sync slowly. // Headed Firefox brings sizes in sync slowly.
if (mViewportWidth && pageWidth > mViewportWidth) if (mViewportWidth && pageWidth > mViewportWidth)
pageWidth = mViewportWidth; pageWidth = mViewportWidth;

4
browser_patches/firefox/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1299 1300
Changed: max@schmitt.mx Mon 1 Nov 2021 16:28:05 CET Changed: yurys@chromium.org Mon 01 Nov 2021 05:00:33 PM PDT

3
browser_patches/firefox/juggler/screencast/nsScreencastService.cpp
View file

@ -159,6 +159,9 @@ class nsScreencastService::Session : public rtc::VideoSinkInterface<webrtc::Vide
void OnRawFrame(uint8_t* videoFrame, size_t videoFrameStride, const webrtc::VideoCaptureCapability& frameInfo) override { void OnRawFrame(uint8_t* videoFrame, size_t videoFrameStride, const webrtc::VideoCaptureCapability& frameInfo) override {
int pageWidth = frameInfo.width - mMargin.LeftRight(); int pageWidth = frameInfo.width - mMargin.LeftRight();
int pageHeight = frameInfo.height - mMargin.TopBottom(); int pageHeight = frameInfo.height - mMargin.TopBottom();
// Frame size is 1x1 when browser window is minimized.
if (pageWidth <= 1 || pageHeight <= 1)
return;
// Headed Firefox brings sizes in sync slowly. // Headed Firefox brings sizes in sync slowly.
if (mViewportWidth && pageWidth > mViewportWidth) if (mViewportWidth && pageWidth > mViewportWidth)
pageWidth = mViewportWidth; pageWidth = mViewportWidth;