From dddf70cead58ac374bc1a6f734953e723a034172 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 19 Oct 2021 17:03:15 -0700 Subject: [PATCH] tests: fix variety of tests (#9630) --- tests/headful.spec.ts | 4 ++-- tests/inspector/cli-codegen-1.spec.ts | 2 +- tests/page/selectors-css.spec.ts | 2 +- tests/snapshotter.spec.ts | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/headful.spec.ts b/tests/headful.spec.ts index fdd19505bd..a1570f770a 100644 --- a/tests/headful.spec.ts +++ b/tests/headful.spec.ts @@ -183,7 +183,7 @@ it('Page.bringToFront should work', async ({ browserType, browserOptions }) => { await browser.close(); }); -it('should click in OOPIF', async ({ browserName, browserType, browserOptions, createUserDataDir, server }) => { +it.skip('should click in OOPIF', async ({ browserName, browserType, browserOptions, createUserDataDir, server }) => { it.fixme(browserName === 'chromium'); server.setRoute('/empty.html', (req, res) => { res.writeHead(200, { 'Content-Type': 'text/html' }); @@ -204,7 +204,7 @@ it('should click in OOPIF', async ({ browserName, browserType, browserOptions, c expect(consoleLog).toContain('ok'); }); -it('should click bottom row w/ infobar in OOPIF', async ({ browserType, browserOptions, createUserDataDir, server }) => { +it.skip('should click bottom row w/ infobar in OOPIF', async ({ browserType, browserOptions, createUserDataDir, server }) => { server.setRoute('/empty.html', (req, res) => { res.writeHead(200, { 'Content-Type': 'text/html' }); res.end(` diff --git a/tests/inspector/cli-codegen-1.spec.ts b/tests/inspector/cli-codegen-1.spec.ts index 4e07ef486b..ed27f426a5 100644 --- a/tests/inspector/cli-codegen-1.spec.ts +++ b/tests/inspector/cli-codegen-1.spec.ts @@ -212,7 +212,7 @@ test.describe('cli codegen', () => { // Sanity check that selector does not match our highlight. const divContents = await page.$eval(selector, div => div.outerHTML); - expect(divContents).toBe(`
Some long text here
`); + expect(divContents.replace(/\s__playwright_target__="[^"]+"/, '')).toBe(`
Some long text here
`); const [message, sources] = await Promise.all([ page.waitForEvent('console', msg => msg.type() !== 'error'), diff --git a/tests/page/selectors-css.spec.ts b/tests/page/selectors-css.spec.ts index 57dea7ff9e..82bcac2969 100644 --- a/tests/page/selectors-css.spec.ts +++ b/tests/page/selectors-css.spec.ts @@ -389,7 +389,7 @@ it('should absolutize relative selectors', async ({ page, server }) => { await page.setContent(`
Hi
`); expect(await page.$eval('div >> >span', e => e.textContent)).toBe('Hi'); expect(await page.locator('div').locator('>span').textContent()).toBe('Hi'); - expect(await page.$eval('div:has(> span)', e => e.outerHTML)).toBe('
Hi
'); + expect((await page.$eval('div:has(> span)', e => e.outerHTML)).replace(/\s__playwright_target__="[^"]+"/, '')).toBe('
Hi
'); expect(await page.$('div:has(> div)')).toBe(null); }); diff --git a/tests/snapshotter.spec.ts b/tests/snapshotter.spec.ts index 398e477069..7ebf2245d5 100644 --- a/tests/snapshotter.spec.ts +++ b/tests/snapshotter.spec.ts @@ -192,6 +192,7 @@ function distillSnapshot(snapshot) { .replace(//, '') .replace(/<\/HTML>/, '') .replace(//, '') + .replace(/\s__playwright_target__="[^"]+"/, '') .replace(/<\/HEAD>/, '') .replace(//, '') .replace(/<\/BODY>/, '').trim();