Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: install chromium along with ffmpeg (#5774)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-03-10 14:01:35 -08:00 committed by GitHub
parent fea6669473
commit ddfdf8a76a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/installation-tests/installation-tests.sh
View file

@ -407,6 +407,10 @@ function test_playwright_cli_install_should_work {
echo "ERROR: should download chromium" echo "ERROR: should download chromium"
exit 1 exit 1
fi fi
if [[ "${OUTPUT}" != *"ffmpeg"* ]]; then
echo "ERROR: should download ffmpeg"
exit 1
fi
if [[ "${OUTPUT}" == *"webkit"* ]]; then if [[ "${OUTPUT}" == *"webkit"* ]]; then
echo "ERROR: should not download webkit" echo "ERROR: should not download webkit"
exit 1 exit 1
@ -422,6 +426,10 @@ function test_playwright_cli_install_should_work {
echo "ERROR: should not download chromium" echo "ERROR: should not download chromium"
exit 1 exit 1
fi fi
if [[ "${OUTPUT}" == *"ffmpeg"* ]]; then
echo "ERROR: should not download ffmpeg"
exit 1
fi
if [[ "${OUTPUT}" != *"webkit"* ]]; then if [[ "${OUTPUT}" != *"webkit"* ]]; then
echo "ERROR: should download webkit" echo "ERROR: should download webkit"
exit 1 exit 1

2
src/cli/cli.ts
View file

@ -90,6 +90,8 @@ program
process.exit(1); process.exit(1);
} }
} }
if (browserType.length && browserType.includes('chromium'))
browserType = browserType.concat('ffmpeg');
installBrowsers(browserType.length ? browserType : undefined).catch((e: any) => { installBrowsers(browserType.length ? browserType : undefined).catch((e: any) => {
console.log(`Failed to install browsers\n${e}`); console.log(`Failed to install browsers\n${e}`);
process.exit(1); process.exit(1);