Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(webkit): postpone creation of the first page (#4769)

Browse source 
When we create the first page in the default context in headless mode on mac,
it gets NSWindow that is "not visible". Although we call [window setIsVisible:YES],
later on window.isVisible still returns NO.

We create our offscreen "headless" NSWindow directly from applicationDidFinishLaunching:.
Experiments show that delaying this by 100ms makes everything work. As a symptom,
we get applicationDidUnhide: notification that does not happen when we create the window
immediately.

Perhaps, we create the window too early, and there is some essential initialization
that happens after applicationDidFinishLaunching:. However, if we call
[NSApp activateIgnoringOtherApps:YES] like we do in headful mode, everything works.

The only solution that worked so far is creating the first page after a timeout.
This commit is contained in:
Dmitry Gozman 2020-12-29 13:49:39 -08:00 committed by GitHub
parent 9817d1095a
commit ded2bc2396
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/webkit/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1409 1410
Changed: einbinder@chromium.org Wed 23 Dec 2020 08:04:33 AM PST Changed: dgozman@gmail.com Tue Dec 22 18:36:56 PST 2020

20
browser_patches/webkit/embedder/Playwright/mac/AppDelegate.m
View file

@ -250,8 +250,18 @@ const NSActivityOptions ActivityOptions =
if (_noStartupWindow) if (_noStartupWindow)
return; return;
[self createNewPage:0]; // Force creation of the default browser context.
_initialURL = nil; [self defaultConfiguration];
// Creating the first NSWindow immediately makes it invisible in headless mode,
// so we postpone it for 50ms. Experiments show that 10ms is not enough, and 20ms is enough.
// We give it 50ms just in case.
[NSTimer scheduledTimerWithTimeInterval: 0.05
repeats: NO
block:(void *)^(NSTimer* timer)
{
[self createNewPage:0 withURL:_initialURL ? _initialURL : @"about:blank"];
_initialURL = nil;
}];
} }
- (void)_updateNewWindowKeyEquivalents - (void)_updateNewWindowKeyEquivalents
@ -278,7 +288,11 @@ const NSActivityOptions ActivityOptions =
- (WKWebView *)createNewPage:(uint64_t)sessionID - (WKWebView *)createNewPage:(uint64_t)sessionID
{ {
NSString* urlString = _initialURL ? _initialURL : @"about:blank"; return [self createNewPage:sessionID withURL:@"about:blank"];
}
- (WKWebView *)createNewPage:(uint64_t)sessionID withURL:(NSString*)urlString
{
WKWebViewConfiguration *configuration = [self sessionConfiguration:sessionID]; WKWebViewConfiguration *configuration = [self sessionConfiguration:sessionID];
if (_headless) if (_headless)
return [self createHeadlessPage:configuration withURL:urlString]; return [self createHeadlessPage:configuration withURL:urlString];