From df63ae9dcecc29101a4ae7221585f802a93bc830 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 15 Jun 2022 09:32:40 -0700 Subject: [PATCH] docs: update strict routeFromHar default value (#14886) --- docs/src/api/class-browsercontext.md | 2 +- docs/src/api/class-page.md | 2 +- packages/playwright-core/types/types.d.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/src/api/class-browsercontext.md b/docs/src/api/class-browsercontext.md index c47b30bc2f..50f2cd547f 100644 --- a/docs/src/api/class-browsercontext.md +++ b/docs/src/api/class-browsercontext.md @@ -1045,7 +1045,7 @@ If `path` is a relative path, then it is resolved relative to the current workin If set to true any request not found in the HAR file will be aborted. If set to false missing requests will continue normal flow and can be handled by other [Route] handlers or served from other HAR files configured with [`method: BrowserContext.routeFromHar`]. -Defaults to false. +Defaults to true. ### option: BrowserContext.routeFromHar.url - `url` <[string]|[RegExp]> diff --git a/docs/src/api/class-page.md b/docs/src/api/class-page.md index 5073ab1e7d..80b043aecf 100644 --- a/docs/src/api/class-page.md +++ b/docs/src/api/class-page.md @@ -2752,7 +2752,7 @@ If `path` is a relative path, then it is resolved relative to the current workin If set to true any request not found in the HAR file will be aborted. If set to false missing requests will continue normal flow and can be handled by other [Route] handlers or served from other HAR files configured with [`method: Page.routeFromHar`]. -Defaults to false. +Defaults to true. ### option: Page.routeFromHar.url - `url` <[string]|[RegExp]> diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts index 2141fb290c..1c5573b579 100644 --- a/packages/playwright-core/types/types.d.ts +++ b/packages/playwright-core/types/types.d.ts @@ -2985,7 +2985,7 @@ export interface Page { * If set to true any request not found in the HAR file will be aborted. If set to false missing requests will continue * normal flow and can be handled by other [Route] handlers or served from other HAR files configured with * [page.routeFromHar(harPath[, options])](https://playwright.dev/docs/api/class-page#page-route-from-har). Defaults to - * false. + * true. */ strict?: boolean; @@ -6859,7 +6859,7 @@ export interface BrowserContext { * If set to true any request not found in the HAR file will be aborted. If set to false missing requests will continue * normal flow and can be handled by other [Route] handlers or served from other HAR files configured with * [browserContext.routeFromHar(harPath[, options])](https://playwright.dev/docs/api/class-browsercontext#browser-context-route-from-har). - * Defaults to false. + * Defaults to true. */ strict?: boolean;