Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

docs(csharp): refer to net8.0 (new LTS) (#28664)

Browse source
This commit is contained in:
Max Schmitt 2023-12-15 10:32:51 -08:00 committed by GitHub
parent 44c3ad5ceb
commit dfd8f25e6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
docs/src/ci-intro.md
View file

@ -150,10 +150,10 @@ jobs:
- name: Setup dotnet - name: Setup dotnet
uses: actions/setup-dotnet@v3 uses: actions/setup-dotnet@v3
with: with:
dotnet-version: 6.0.x dotnet-version: 8.0.x
- run: dotnet build - run: dotnet build
- name: Ensure browsers are installed - name: Ensure browsers are installed
run: pwsh bin/Debug/net6.0/playwright.ps1 install --with-deps run: pwsh bin/Debug/net8.0/playwright.ps1 install --with-deps
- name: Run your tests - name: Run your tests
run: dotnet test run: dotnet test
``` ```
@ -268,7 +268,7 @@ jobs:
- name: Setup dotnet - name: Setup dotnet
uses: actions/setup-dotnet@v3 uses: actions/setup-dotnet@v3
with: with:
dotnet-version: 6.0.x dotnet-version: 8.0.x
- run: dotnet build - run: dotnet build
- name: Run your tests - name: Run your tests
run: dotnet test run: dotnet test
@ -372,10 +372,10 @@ jobs:
- name: Setup dotnet - name: Setup dotnet
uses: actions/setup-dotnet@v3 uses: actions/setup-dotnet@v3
with: with:
dotnet-version: 6.0.x dotnet-version: 8.0.x
- run: dotnet build - run: dotnet build
- name: Ensure browsers are installed - name: Ensure browsers are installed
run: pwsh bin/Debug/net6.0/playwright.ps1 install --with-deps run: pwsh bin/Debug/net8.0/playwright.ps1 install --with-deps
- name: Run tests - name: Run tests
run: dotnet test run: dotnet test
env: env:

6
docs/src/ci.md
View file

@ -167,11 +167,11 @@ steps:
- task: UseDotNet@2 - task: UseDotNet@2
inputs: inputs:
packageType: sdk packageType: sdk
version: '6.0.x' version: '8.0.x'
displayName: 'Use .NET SDK' displayName: 'Use .NET SDK'
- script: dotnet build --configuration Release - script: dotnet build --configuration Release
displayName: 'Build' displayName: 'Build'
- script: pwsh bin/Release/net6.0/playwright.ps1 install --with-deps - script: pwsh bin/Release/net8.0/playwright.ps1 install --with-deps
displayName: 'Install Playwright browsers' displayName: 'Install Playwright browsers'
- script: dotnet test --configuration Release - script: dotnet test --configuration Release
displayName: 'Run tests' displayName: 'Run tests'
@ -367,7 +367,7 @@ steps:
- task: UseDotNet@2 - task: UseDotNet@2
inputs: inputs:
packageType: sdk packageType: sdk
version: '6.0.x' version: '8.0.x'
displayName: 'Use .NET SDK' displayName: 'Use .NET SDK'
- script: dotnet build --configuration Release - script: dotnet build --configuration Release

2
docs/src/intro-csharp.md
View file

@ -69,7 +69,7 @@ dotnet add package Microsoft.Playwright.MSTest
dotnet build dotnet build
``` ```
4. Install required browsers by replacing `netX` with the actual output folder name, e.g. `net6.0`: 4. Install required browsers by replacing `netX` with the actual output folder name, e.g. `net8.0`:
```bash ```bash
pwsh bin/Debug/netX/playwright.ps1 install pwsh bin/Debug/netX/playwright.ps1 install

2
docs/src/library-csharp.md
View file

@ -20,7 +20,7 @@ cd PlaywrightDemo
dotnet add package Microsoft.Playwright dotnet add package Microsoft.Playwright
# Build the project # Build the project
dotnet build dotnet build
# Install required browsers - replace netX with actual output folder name, e.g. net6.0. # Install required browsers - replace netX with actual output folder name, e.g. net8.0.
pwsh bin/Debug/netX/playwright.ps1 install pwsh bin/Debug/netX/playwright.ps1 install
# If the pwsh command does not work (throws TypeNotFound), make sure to use an up-to-date version of PowerShell. # If the pwsh command does not work (throws TypeNotFound), make sure to use an up-to-date version of PowerShell.

8
docs/src/webview2.md
View file

@ -79,7 +79,7 @@ import childProcess from 'child_process';
const EXECUTABLE_PATH = path.join( const EXECUTABLE_PATH = path.join(
__dirname, __dirname,
'../../webview2-app/bin/Debug/net6.0-windows/webview2.exe', '../../webview2-app/bin/Debug/net8.0-windows/webview2.exe',
); );
export const test = base.extend({ export const test = base.extend({
@ -148,7 +148,7 @@ public class WebView2Process {
public int cdpPort; public int cdpPort;
private Path _dataDir; private Path _dataDir;
private Process _process; private Process _process;
private Path _executablePath = Path.of("../webview2-app/bin/Debug/net6.0-windows/webview2.exe"); private Path _executablePath = Path.of("../webview2-app/bin/Debug/net8.0-windows/webview2.exe");
public WebView2Process() throws IOException { public WebView2Process() throws IOException {
cdpPort = nextFreePort(); cdpPort = nextFreePort();
@ -268,7 +268,7 @@ EXECUTABLE_PATH = (
/ "webview2-app" / "webview2-app"
/ "bin" / "bin"
/ "Debug" / "Debug"
/ "net6.0-windows" / "net8.0-windows"
/ "webview2.exe" / "webview2.exe"
) )
@ -361,7 +361,7 @@ public class WebView2Test : PlaywrightTest
public IPage Page { get; internal set; } = null!; public IPage Page { get; internal set; } = null!;
private Process? _webView2Process = null; private Process? _webView2Process = null;
private string _userDataDir = null!; private string _userDataDir = null!;
private string _executablePath = Path.Join(Directory.GetCurrentDirectory(), @"..\..\..\..\webview2-app\bin\Debug\net6.0-windows\webview2.exe"); private string _executablePath = Path.Join(Directory.GetCurrentDirectory(), @"..\..\..\..\webview2-app\bin\Debug\net8.0-windows\webview2.exe");
[SetUp] [SetUp]
public async Task BrowserSetUp() public async Task BrowserSetUp()