Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: rebase permission test for Chromium >= 110 (#19899)

Browse source 
Fixes #19180.
This commit is contained in:
Dmitry Gozman 2023-01-05 13:01:37 -08:00 committed by GitHub
parent 2f4b5ea371
commit e07d1722ec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tests/library/permissions.spec.ts
View file

@ -100,10 +100,8 @@ it.describe('permissions', () => {
expect(await getPermission(page, 'geolocation')).toBe('prompt'); expect(await getPermission(page, 'geolocation')).toBe('prompt');
}); });
it('should trigger permission onchange', async ({ page, context, server, browserName, headless, browserMajorVersion }) => { it('should trigger permission onchange', async ({ page, context, server, browserName, browserMajorVersion }) => {
it.fail(browserName === 'webkit'); it.fail(browserName === 'webkit');
it.fail(browserName === 'chromium' && !headless && browserMajorVersion <= 102, 'Fixed on ToT, remove once Beta rolls');
it.fixme(browserName === 'chromium' && browserMajorVersion >= 110, 'https://github.com/microsoft/playwright/issues/19180');
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => { await page.evaluate(() => {
@ -121,7 +119,12 @@ it.describe('permissions', () => {
await context.grantPermissions(['geolocation'], { origin: server.EMPTY_PAGE }); await context.grantPermissions(['geolocation'], { origin: server.EMPTY_PAGE });
expect(await page.evaluate(() => window['events'])).toEqual(['prompt', 'denied', 'granted']); expect(await page.evaluate(() => window['events'])).toEqual(['prompt', 'denied', 'granted']);
await context.clearPermissions(); await context.clearPermissions();
expect(await page.evaluate(() => window['events'])).toEqual(['prompt', 'denied', 'granted', 'prompt']);
// Note: Chromium 110 stopped triggering "onchange" when clearing permissions.
expect(await page.evaluate(() => window['events'])).toEqual(
(browserName === 'chromium' && browserMajorVersion >= 110) ?
['prompt', 'denied', 'granted'] :
['prompt', 'denied', 'granted', 'prompt']);
}); });
it('should isolate permissions between browser contexts', async ({ server, browser }) => { it('should isolate permissions between browser contexts', async ({ server, browser }) => {