From e0cbb0882b7cecfb7003967ad32e7a6de2256d10 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 26 Jul 2023 16:16:00 -0700 Subject: [PATCH] fix(launch): default to non-zero launch timeout (#24440) When not specified, launch timeout is 3 minutes, taken from the `DEFAULT_LAUNCH_TIMEOUT` constant. Also, use the default launch timeout for `electron.launch()` instead of default regular timeout. --- packages/playwright-core/src/server/electron/electron.ts | 2 +- packages/playwright-test/src/index.ts | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/electron/electron.ts b/packages/playwright-core/src/server/electron/electron.ts index 07369d5991..90f90aad07 100644 --- a/packages/playwright-core/src/server/electron/electron.ts +++ b/packages/playwright-core/src/server/electron/electron.ts @@ -239,7 +239,7 @@ export class Electron extends SdkObject { app = new ElectronApplication(this, browser, nodeConnection, launchedProcess); await app.initialize(); return app; - }, TimeoutSettings.timeout(options)); + }, TimeoutSettings.launchTimeout(options)); } } diff --git a/packages/playwright-test/src/index.ts b/packages/playwright-test/src/index.ts index 301ae79cfa..a5b56be61e 100644 --- a/packages/playwright-test/src/index.ts +++ b/packages/playwright-test/src/index.ts @@ -94,7 +94,6 @@ const playwrightFixtures: Fixtures = ({ _browserOptions: [async ({ playwright, headless, channel, launchOptions, connectOptions, _artifactsDir }, use) => { const options: LaunchOptions = { handleSIGINT: false, - timeout: 0, ...launchOptions, }; if (headless !== undefined)