From e15fc08d4693ef8c15f3784e67c899540166b1ed Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 7 Apr 2020 07:40:57 -0700 Subject: [PATCH] chore: migrate node types to 10.17.17 (#1690) --- package.json | 2 +- src/server/chromium.ts | 3 ++- src/server/webkit.ts | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 645099c697..498d846c7d 100644 --- a/package.json +++ b/package.json @@ -58,7 +58,7 @@ "@types/debug": "0.0.31", "@types/extract-zip": "^1.6.2", "@types/mime": "^2.0.1", - "@types/node": "^8.10.34", + "@types/node": "^10.17.17", "@types/pngjs": "^3.4.0", "@types/proxy-from-env": "^1.0.0", "@types/rimraf": "^2.0.2", diff --git a/src/server/chromium.ts b/src/server/chromium.ts index fc55760c46..43c238b2ae 100644 --- a/src/server/chromium.ts +++ b/src/server/chromium.ts @@ -128,7 +128,8 @@ export class Chromium implements BrowserType { let transport: PipeTransport | undefined = undefined; let browserServer: BrowserServer | undefined = undefined; - transport = new PipeTransport(launchedProcess.stdio[3] as NodeJS.WritableStream, launchedProcess.stdio[4] as NodeJS.ReadableStream); + const stdio = launchedProcess.stdio as unknown as [NodeJS.ReadableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.ReadableStream]; + transport = new PipeTransport(stdio[3], stdio[4]); browserServer = new BrowserServer(launchedProcess, gracefullyClose, launchType === 'server' ? wrapTransportWithWebSocket(transport, port) : null); return { browserServer, transport, downloadsPath }; } diff --git a/src/server/webkit.ts b/src/server/webkit.ts index 0ec61cddb7..bc3a158235 100644 --- a/src/server/webkit.ts +++ b/src/server/webkit.ts @@ -128,7 +128,8 @@ export class WebKit implements BrowserType { // For local launch scenario close will terminate the browser process. let transport: ConnectionTransport | undefined = undefined; let browserServer: BrowserServer | undefined = undefined; - transport = new PipeTransport(launchedProcess.stdio[3] as NodeJS.WritableStream, launchedProcess.stdio[4] as NodeJS.ReadableStream); + const stdio = launchedProcess.stdio as unknown as [NodeJS.ReadableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.WritableStream, NodeJS.ReadableStream]; + transport = new PipeTransport(stdio[3], stdio[4]); browserServer = new BrowserServer(launchedProcess, gracefullyClose, launchType === 'server' ? wrapTransportWithWebSocket(transport, port || 0) : null); return { browserServer, transport, downloadsPath }; }