Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#21942): chore: show global setup errors in ui mode

Browse source
This commit is contained in:
Pavel Feldman 2023-03-23 15:46:24 -07:00
parent 72382faddc
commit e169cd394a
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/playwright-test/src/runner/uiMode.ts
View file

@ -66,7 +66,7 @@ class UIMode {
} }
async runGlobalSetup(): Promise<FullResult['status']> { async runGlobalSetup(): Promise<FullResult['status']> {
const reporter = await createReporter(this._config, 'watch'); const reporter = await createReporter(this._config, 'run');
const taskRunner = createTaskRunnerForWatchSetup(this._config, reporter); const taskRunner = createTaskRunnerForWatchSetup(this._config, reporter);
reporter.onConfigure(this._config); reporter.onConfigure(this._config);
const context: TaskRunnerState = { const context: TaskRunnerState = {
@ -75,6 +75,7 @@ class UIMode {
phases: [], phases: [],
}; };
const { status, cleanup: globalCleanup } = await taskRunner.runDeferCleanup(context, 0); const { status, cleanup: globalCleanup } = await taskRunner.runDeferCleanup(context, 0);
await reporter.onExit({ status });
if (status !== 'passed') { if (status !== 'passed') {
await globalCleanup(); await globalCleanup();
return status; return status;
@ -151,7 +152,7 @@ class UIMode {
clearCompilationCache(); clearCompilationCache();
reporter.onConfigure(this._config); reporter.onConfigure(this._config);
const status = await taskRunner.run(context, 0); const status = await taskRunner.run(context, 0);
reporter.onExit({ status }); await reporter.onExit({ status });
const projectDirs = new Set<string>(); const projectDirs = new Set<string>();
for (const p of this._config.projects) for (const p of this._config.projects)