Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: do not specify custom LD_LIBRARY_PATH for Firefox (#16681)

Browse source 
We used to bundle `libstdc++` for Firefox but we no longer do so,
so this code should not be needed.
This commit is contained in:
Andrey Lushnikov 2022-08-19 07:18:41 -07:00 committed by GitHub
parent be33ec817b
commit e1e1035e10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/server/firefox/firefox.ts
View file

@ -46,13 +46,6 @@ export class Firefox extends BrowserType {
_amendEnvironment(env: Env, userDataDir: string, executable: string, browserArguments: string[]): Env { _amendEnvironment(env: Env, userDataDir: string, executable: string, browserArguments: string[]): Env {
if (!path.isAbsolute(os.homedir())) if (!path.isAbsolute(os.homedir()))
throw new Error(`Cannot launch Firefox with relative home directory. Did you set ${os.platform() === 'win32' ? 'USERPROFILE' : 'HOME'} to a relative path?`); throw new Error(`Cannot launch Firefox with relative home directory. Did you set ${os.platform() === 'win32' ? 'USERPROFILE' : 'HOME'} to a relative path?`);
if (os.platform() === 'linux') {
return {
...env,
// On linux Juggler ships the libstdc++ it was linked against.
LD_LIBRARY_PATH: `${path.dirname(executable)}:${process.env.LD_LIBRARY_PATH}`,
};
}
return env; return env;
} }