From e234a6a037f1385ccfdf8a7e57883a587a97584d Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Mon, 10 Jul 2023 18:36:15 -0700 Subject: [PATCH] chore: make tracing before/after test more robust (#24136) --- tests/library/tracing.spec.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.ts index f9df80587a..980b9706ed 100644 --- a/tests/library/tracing.spec.ts +++ b/tests/library/tracing.spec.ts @@ -735,32 +735,40 @@ test('should not emit after w/o before', async ({ browserType, mode }, testInfo) } }; + let call1: number; { const { events } = await parseTraceRaw(testInfo.outputPath('trace1.zip')); expect(events.map(sanitize).filter(Boolean)).toEqual([ { type: 'before', - callId: 0, + callId: expect.any(Number), apiName: 'page.evaluate' } ]); + call1 = events.map(sanitize).filter(Boolean)[0].callId; } + let call2before: number; + let call2after: number; { const { events } = await parseTraceRaw(testInfo.outputPath('trace2.zip')); expect(events.map(sanitize).filter(Boolean)).toEqual([ { type: 'before', - callId: 6, + callId: expect.any(Number), apiName: 'page.evaluateHandle' }, { type: 'after', - callId: 6, + callId: expect.any(Number), apiName: undefined } ]); + call2before = events.map(sanitize).filter(Boolean)[0].callId; + call2after = events.map(sanitize).filter(Boolean)[1].callId; } + expect(call2before).toBeGreaterThan(call1); + expect(call2after).toBe(call2before); }); function expectRed(pixels: Buffer, offset: number) {