Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: unshift shortest whitespace prefix only (#33618)

Browse source
This commit is contained in:
Yury Semikhatsky 2024-11-15 12:47:25 -08:00 committed by GitHub
parent 77dee44984
commit e24780f825
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright/src/matchers/toMatchAriaSnapshot.ts
View file

@ -126,7 +126,6 @@ function unshift(snapshot: string): string {
const match = line.match(/^(\s*)/); const match = line.match(/^(\s*)/);
if (match && match[1].length < whitespacePrefixLength) if (match && match[1].length < whitespacePrefixLength)
whitespacePrefixLength = match[1].length; whitespacePrefixLength = match[1].length;
break;
} }
return lines.filter(t => t.trim()).map(line => line.substring(whitespacePrefixLength)).join('\n'); return lines.filter(t => t.trim()).map(line => line.substring(whitespacePrefixLength)).join('\n');
} }

1
tests/page/page-aria-snapshot.spec.ts
View file

@ -27,7 +27,6 @@ function unshift(snapshot: string): string {
const match = line.match(/^(\s*)/); const match = line.match(/^(\s*)/);
if (match && match[1].length < whitespacePrefixLength) if (match && match[1].length < whitespacePrefixLength)
whitespacePrefixLength = match[1].length; whitespacePrefixLength = match[1].length;
break;
} }
return lines.filter(t => t.trim()).map(line => line.substring(whitespacePrefixLength)).join('\n'); return lines.filter(t => t.trim()).map(line => line.substring(whitespacePrefixLength)).join('\n');
} }

14
tests/page/to-match-aria-snapshot.spec.ts
View file

@ -659,3 +659,17 @@ test('should parse attributes', async ({ page }) => {
`); `);
} }
}); });
test('should not unshift actual template text', async ({ page }) => {
await page.setContent(`
<h1>title</h1>
<h1>title 2</h1>
`);
const error = await expect(page.locator('body')).toMatchAriaSnapshot(`
- heading "title" [level=1]
- heading "title 2" [level=1]
`, { timeout: 1000 }).catch(e => e);
expect(stripAnsi(error.message)).toContain(`
- heading "title" [level=1]
- heading "title 2" [level=1]`);
});