Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: fix //utils/workspace.js --set-version script (#13409)

Browse source 
We use this script to update packages version across our repository.
It was broken because it did not account for the devDependencies.
This commit is contained in:
Andrey Lushnikov 2022-04-07 15:46:43 -06:00 committed by GitHub
parent f7119ef597
commit e3450b86f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
utils/workspace.js
View file

@ -123,10 +123,14 @@ class Workspace {
for (const otherPackage of this._packages) { for (const otherPackage of this._packages) {
if (pkgLockEntry.dependencies && pkgLockEntry.dependencies[otherPackage.name]) if (pkgLockEntry.dependencies && pkgLockEntry.dependencies[otherPackage.name])
pkgLockEntry.dependencies[otherPackage.name] = version; pkgLockEntry.dependencies[otherPackage.name] = version;
if (pkgLockEntry.devDependencies && pkgLockEntry.devDependencies[otherPackage.name])
pkgLockEntry.devDependencies[otherPackage.name] = version;
if (depLockEntry.requires && depLockEntry.requires[otherPackage.name]) if (depLockEntry.requires && depLockEntry.requires[otherPackage.name])
depLockEntry.requires[otherPackage.name] = version; depLockEntry.requires[otherPackage.name] = version;
if (pkg.packageJSON.dependencies && pkg.packageJSON.dependencies[otherPackage.name]) if (pkg.packageJSON.dependencies && pkg.packageJSON.dependencies[otherPackage.name])
pkg.packageJSON.dependencies[otherPackage.name] = version; pkg.packageJSON.dependencies[otherPackage.name] = version;
if (pkg.packageJSON.devDependencies && pkg.packageJSON.devDependencies[otherPackage.name])
pkg.packageJSON.devDependencies[otherPackage.name] = version;
} }
await maybeWriteJSON(pkg.packageJSONPath, pkg.packageJSON); await maybeWriteJSON(pkg.packageJSONPath, pkg.packageJSON);
} }