From e3bd7ce1193c8b3b6b4dfb73916217c02e70299c Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 14 Mar 2022 18:20:17 -0600 Subject: [PATCH] fix(test-runner): resolve outputDir wrt rootDir (#12755) Currently, running `npx playwright test` in a subfolder of your project will result in a `test-results` folder created in your `cwd`. This is unexpected; instead, we should always resolve all paths against `rootDir` - directory that contains config. --- packages/playwright-test/src/loader.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright-test/src/loader.ts b/packages/playwright-test/src/loader.ts index f3a0e6d021..767287ce42 100644 --- a/packages/playwright-test/src/loader.ts +++ b/packages/playwright-test/src/loader.ts @@ -196,7 +196,7 @@ export class Loader { let testDir = takeFirst(projectConfig.testDir, rootDir); if (!path.isAbsolute(testDir)) testDir = path.resolve(configDir, testDir); - let outputDir = takeFirst(this._configOverrides.outputDir, projectConfig.outputDir, this._config.outputDir, path.resolve(process.cwd(), 'test-results')); + let outputDir = takeFirst(this._configOverrides.outputDir, projectConfig.outputDir, this._config.outputDir, path.resolve(rootDir, 'test-results')); if (!path.isAbsolute(outputDir)) outputDir = path.resolve(configDir, outputDir); let snapshotDir = takeFirst(this._configOverrides.snapshotDir, projectConfig.snapshotDir, this._config.snapshotDir, testDir);