From e3cd52d0df3f0547ba5e3cd5eaa9d41fa974b278 Mon Sep 17 00:00:00 2001
From: Joel Einbinder <joel.einbinder@gmail.com>
Date: Tue, 23 Feb 2021 17:03:28 -0800
Subject: [PATCH] test(drag): enable drag tests everywhere but chromium (#5553)

---
 test/page-drag.spec.ts | 124 ++++++++++++++++-------------------------
 1 file changed, 49 insertions(+), 75 deletions(-)

diff --git a/test/page-drag.spec.ts b/test/page-drag.spec.ts
index adb39d2adf..272bf9c090 100644
--- a/test/page-drag.spec.ts
+++ b/test/page-drag.spec.ts
@@ -17,8 +17,8 @@ import { ElementHandle } from '..';
 import { it, expect, describe } from './fixtures';
 import { attachFrame } from './utils';
 
-describe('Drag and drop', test => {
-  test.fixme();
+describe('Drag and drop', (test, {browserName}) => {
+  test.fixme(browserName === 'chromium');
 }, () => {
   it('should work', async ({server, page, context}) => {
     await page.goto(server.PREFIX + '/drag-n-drop.html');
@@ -69,80 +69,54 @@ describe('Drag and drop', test => {
     ]);
   });
 
-  it('should drag into an iframe', async ({server, page, isFirefox}) => {
-    await page.goto(server.PREFIX + '/drag-n-drop.html');
-    const frame = await attachFrame(page, 'oopif',server.CROSS_PROCESS_PREFIX + '/drag-n-drop.html');
-    const pageEvents = await trackEvents(await page.$('body'));
-    const frameEvents = await trackEvents(await frame.$('body'));
-    await page.hover('#source');
-    await page.mouse.down();
-    await frame.hover('#target');
-    await page.mouse.up();
-    expect(await frame.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
-    expect(await pageEvents.jsonValue()).toEqual([
-      'mousemove',
-      'mousedown',
-      isFirefox ? 'dragstart' : 'mousemove',
-      isFirefox ? 'mousemove' : 'dragstart',
-    ]);
-    expect(await frameEvents.jsonValue()).toEqual([
-      'dragenter',
-      'dragover',
-      'drop',
-    ]);
-  });
+  describe('iframe', (test, {}) => {
+    test.fixme('implement dragging with iframes');
+  }, () => {
+    it('should drag into an iframe', async ({server, page, isFirefox}) => {
+      await page.goto(server.PREFIX + '/drag-n-drop.html');
+      const frame = await attachFrame(page, 'oopif',server.PREFIX + '/drag-n-drop.html');
+      const pageEvents = await trackEvents(await page.$('body'));
+      const frameEvents = await trackEvents(await frame.$('body'));
+      await page.pause();
+      await page.hover('#source');
+      await page.mouse.down();
+      await frame.hover('#target');
+      await page.mouse.up();
+      expect(await frame.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
+      expect(await pageEvents.jsonValue()).toEqual([
+        'mousemove',
+        'mousedown',
+        isFirefox ? 'dragstart' : 'mousemove',
+        isFirefox ? 'mousemove' : 'dragstart',
+      ]);
+      expect(await frameEvents.jsonValue()).toEqual([
+        'dragenter',
+        'dragover',
+        'drop',
+      ]);
+    });
 
-  it('should drag out of an iframe', async ({server, page}) => {
-    await page.goto(server.PREFIX + '/drag-n-drop.html');
-    const frame = await attachFrame(page, 'oopif',server.CROSS_PROCESS_PREFIX + '/drag-n-drop.html');
-    const pageEvents = await trackEvents(await page.$('body'));
-    const frameEvents = await trackEvents(await frame.$('body'));
-    await frame.hover('#source');
-    await page.mouse.down();
-    await page.hover('#target');
-    await page.mouse.up();
-    expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
-    expect(await frameEvents.jsonValue()).toEqual([
-      'mousemove',
-      'mousedown',
-      'dragstart',
-    ]);
-    expect(await pageEvents.jsonValue()).toEqual([
-      'dragenter',
-      'dragover',
-      'drop',
-    ]);
-  });
-
-  it('should drag through a navigation', async ({server, page, isFirefox}) => {
-    await page.goto(server.PREFIX + '/drag-n-drop.html');
-    const beforeNavigationEvents = await trackEvents(await page.$('body'));
-    await page.hover('#source');
-    await page.mouse.down();
-    // start the drag
-    await page.mouse.move(50, 50);
-
-    expect(await beforeNavigationEvents.jsonValue()).toEqual([
-      'mousemove',
-      'mousedown',
-      isFirefox ? 'dragstart' : 'mousemove',
-      isFirefox ? 'mousemove' : 'dragstart',
-      'dragenter',
-      'dragover',
-    ]);
-
-    await page.reload();
-    const afterNavigationEvents = await trackEvents(await page.$('body'));
-
-    await page.hover('#target');
-    await page.mouse.up();
-
-    expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
-    expect(await afterNavigationEvents.jsonValue()).toEqual([
-      'dragenter',
-      'dragover',
-      'drop',
-    ]);
+    it('should drag out of an iframe', async ({server, page}) => {
+      await page.goto(server.PREFIX + '/drag-n-drop.html');
+      const frame = await attachFrame(page, 'oopif',server.PREFIX + '/drag-n-drop.html');
+      const pageEvents = await trackEvents(await page.$('body'));
+      const frameEvents = await trackEvents(await frame.$('body'));
+      await frame.hover('#source');
+      await page.mouse.down();
+      await page.hover('#target');
+      await page.mouse.up();
+      expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true); // could not find source in target
+      expect(await frameEvents.jsonValue()).toEqual([
+        'mousemove',
+        'mousedown',
+        'dragstart',
+      ]);
+      expect(await pageEvents.jsonValue()).toEqual([
+        'dragenter',
+        'dragover',
+        'drop',
+      ]);
+    });
   });
 
   it('should respect the drop effect', (test, {browserName}) => {