Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: enable user agent override for download in Chromium (#23479)

Browse source 
Fixes #22843.
This commit is contained in:
Dmitry Gozman 2023-06-02 15:02:54 -07:00 committed by GitHub
parent 00f662531e
commit e4a1273afa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/library/browsercontext-user-agent.spec.ts
View file

@ -17,6 +17,7 @@
import { browserTest as it, expect } from '../config/browserTest'; import { browserTest as it, expect } from '../config/browserTest';
import { attachFrame } from '../config/utils'; import { attachFrame } from '../config/utils';
import { chromiumVersionLessThan } from '../config/utils';
it('should work', async ({ browser, server }) => { it('should work', async ({ browser, server }) => {
{ {
@ -86,9 +87,16 @@ it('should make a copy of default options', async ({ browser, server }) => {
await context.close(); await context.close();
}); });
it('custom user agent for download', async ({ server, contextFactory, browserName }) => { it('custom user agent for download', async ({ server, contextFactory, browserVersion, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22843' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22843' });
it.skip(browserName === 'chromium'); it.skip(browserName === 'chromium' && chromiumVersionLessThan(browserVersion, '116.0.0.0'), 'https://chromium-review.googlesource.com/c/chromium/src/+/4554578');
server.setRoute('/download', (req, res) => {
res.setHeader('Content-Type', 'application/octet-stream');
res.setHeader('Content-Disposition', 'attachment');
res.end(`Hello world`);
});
const context = await contextFactory({ userAgent: 'MyCustomUA' }); const context = await contextFactory({ userAgent: 'MyCustomUA' });
const page = await context.newPage(); const page = await context.newPage();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);