From e53500a2e49fa82ddd934310a15a8b6fb78f85ac Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 13 Dec 2024 12:50:39 -0800 Subject: [PATCH] enable in firefox --- tests/page/page-evaluate.spec.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/page/page-evaluate.spec.ts b/tests/page/page-evaluate.spec.ts index 292ff65d6e..8cbe594e27 100644 --- a/tests/page/page-evaluate.spec.ts +++ b/tests/page/page-evaluate.spec.ts @@ -403,16 +403,17 @@ it('should return undefined for non-serializable objects', async ({ page }) => { it('should throw for too deep reference chain', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/33997' } }, async ({ page, browserName }) => { - it.fixme(browserName === 'firefox', 'Firefox does not throw on long chain yet.'); - await expect(page.evaluate((depth) => { + await expect(page.evaluate(depth => { const obj = {}; let temp = obj; for (let i = 0; i < depth; i++) { temp[i] = {}; temp = temp[i]; } - return obj - }, 1000)).rejects.toThrow('Cannot serialize result: object reference chain is too long.'); + return obj; + }, 1000)).rejects.toThrow(browserName === 'firefox' + ? 'Maximum call stack size exceeded' + : 'Cannot serialize result: object reference chain is too long.'); }); it('should alias Window, Document and Node', async ({ page }) => {