From e5d4cfb86e46770ffcb3444ece1ec9663eade62e Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Fri, 10 Jan 2025 14:20:04 +0100 Subject: [PATCH] chore(bidi): Fix naming of argument for getBidiKeyValue which should be code and not key --- .../src/server/bidi/third_party/bidiKeyboard.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts b/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts index 307d83fb87..2b07c281ab 100644 --- a/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts +++ b/packages/playwright-core/src/server/bidi/third_party/bidiKeyboard.ts @@ -7,18 +7,18 @@ /* eslint-disable curly */ -export const getBidiKeyValue = (key: string) => { - switch (key) { +export const getBidiKeyValue = (code: string) => { + switch (code) { case '\r': case '\n': - key = 'Enter'; + code = 'Enter'; break; } // Measures the number of code points rather than UTF-16 code units. - if ([...key].length === 1) { - return key; + if ([...code].length === 1) { + return code; } - switch (key) { + switch (code) { case 'Cancel': return '\uE001'; case 'Help': @@ -226,6 +226,6 @@ export const getBidiKeyValue = (key: string) => { case 'Quote': return '"'; default: - throw new Error(`Unknown key: "${key}"`); + throw new Error(`Unknown key: "${code}"`); } };