Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(devops): auto roll tests (#3536)

Browse source
This commit is contained in:
Max Schmitt 2020-08-20 00:04:52 +02:00 committed by GitHub
parent a78d83e833
commit e679b82339
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/auto_roll.yml vendored
View file

@ -27,12 +27,11 @@ jobs:
# XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
# Wrap `npm run` in a subshell to redirect STDERR to file. # Wrap `npm run` in a subshell to redirect STDERR to file.
# Enable core dumps in the subshell. # Enable core dumps in the subshell.
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && node test/runner test/ --jobs=1 --forbid-only --timeout=30000 && npm run coverage" - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && node test/runner test/ --jobs=1 --forbid-only --timeout=30000"
env: env:
BROWSER: ${{ matrix.browser }} BROWSER: ${{ matrix.browser }}
DEBUG: "pw:*,-pw:wrapped*,-pw:test*" DEBUG: "pw:*,-pw:wrapped*,-pw:test*"
DEBUG_FILE: "testrun.log" DEBUG_FILE: "testrun.log"
PWCHANNEL: none
FFPATH: ${{ steps.build-browser.outputs.FFPATH }} FFPATH: ${{ steps.build-browser.outputs.FFPATH }}
WKPATH: ${{ steps.build-browser.outputs.WKPATH }} WKPATH: ${{ steps.build-browser.outputs.WKPATH }}
- uses: actions/upload-artifact@v1 - uses: actions/upload-artifact@v1

3
test/base.fixture.ts
View file

@ -152,9 +152,6 @@ registerFixture('toImpl', async ({playwright}, test) => {
registerWorkerFixture('browserType', async ({playwright, browserName}, test) => { registerWorkerFixture('browserType', async ({playwright, browserName}, test) => {
const browserType = playwright[browserName]; const browserType = playwright[browserName];
const executablePath = getExecutablePath(browserName)
if (executablePath)
browserType._executablePath = executablePath
await test(browserType); await test(browserType);
}); });

2
test/browsertype-basic.spec.ts
View file

@ -18,7 +18,7 @@
import fs from 'fs'; import fs from 'fs';
import './base.fixture'; import './base.fixture';
it('browserType.executablePath should work', async({browserType}) => { it.skip(Boolean(process.env.CRPATH || process.env.FFPATH || process.env.WKPATH))('browserType.executablePath should work', async({browserType}) => {
const executablePath = browserType.executablePath(); const executablePath = browserType.executablePath();
expect(fs.existsSync(executablePath)).toBe(true); expect(fs.existsSync(executablePath)).toBe(true);
expect(fs.realpathSync(executablePath)).toBe(executablePath); expect(fs.realpathSync(executablePath)).toBe(executablePath);