Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: update evaluate-no-stall test to get a proper error (#6973)

Browse source 
This test is flaky, and gives us "expected true, got false".
We should see the actual error message instead.
This commit is contained in:
Dmitry Gozman 2021-06-08 16:27:44 -07:00 committed by GitHub
parent aa2546592d
commit e707207d6f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/page/page-evaluate-no-stall.spec.ts
View file

@ -48,7 +48,9 @@ test.describe('non-stalling evaluate', () => {
if (error === 4)
return;
// Testing this as a race.
const success = error.message === 'Frame does not yet have a main execution context' || error.message === 'Frame is currently attempting a navigation';
expect(success).toBeTruthy();
expect([
'Frame does not yet have a main execution context',
'Frame is currently attempting a navigation'
]).toContain(error.message);
});
});