From e832038ea21ad0c9bb51875ca277ee4b38f66769 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 7 Sep 2021 11:17:09 +0200 Subject: [PATCH] test: skip wss/https tests which were failing on transport mode (#8733) --- tests/browsertype-connect.spec.ts | 3 ++- tests/chromium/chromium.spec.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/browsertype-connect.spec.ts b/tests/browsertype-connect.spec.ts index 04acbdd202..66b3eebb81 100644 --- a/tests/browsertype-connect.spec.ts +++ b/tests/browsertype-connect.spec.ts @@ -23,7 +23,8 @@ import WebSocket from 'ws'; test.slow(true, 'All connect tests are slow'); -test('should connect over wss', async ({browserType , startRemoteServer, httpsServer}) => { +test('should connect over wss', async ({browserType , startRemoteServer, httpsServer, mode}) => { + test.skip(mode !== 'default'); // Out of process transport does not allow us to set env vars dynamically. const remoteServer = await startRemoteServer(); const oldValue = process.env['NODE_TLS_REJECT_UNAUTHORIZED']; diff --git a/tests/chromium/chromium.spec.ts b/tests/chromium/chromium.spec.ts index e6fd8ac594..351b07071a 100644 --- a/tests/chromium/chromium.spec.ts +++ b/tests/chromium/chromium.spec.ts @@ -286,7 +286,8 @@ playwrightTest('should report all pages in an existing browser', async ({ browse } }); -playwrightTest('should connect via https', async ({ browserType, browserOptions, httpsServer }, testInfo) => { +playwrightTest('should connect via https', async ({ browserType, browserOptions, httpsServer, mode }, testInfo) => { + test.skip(mode !== 'default'); // Out of process transport does not allow us to set env vars dynamically. const port = 9339 + testInfo.workerIndex; const browserServer = await browserType.launch({ ...browserOptions,