Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(lint): import errors (#1649)

Browse source
This commit is contained in:
Dmitry Gozman 2020-04-02 20:30:52 -07:00 committed by GitHub
parent a9be3c5191
commit ea16e55ba3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/chromium/crBrowser.ts
View file

@ -29,7 +29,7 @@ import { readProtocolStream } from './crProtocolHelper';
import { Events } from './events'; import { Events } from './events';
import { Protocol } from './protocol'; import { Protocol } from './protocol';
import { CRExecutionContext } from './crExecutionContext'; import { CRExecutionContext } from './crExecutionContext';
import type { BrowserServer } from '../server/browserServer'; import { BrowserServer } from '../server/browserServer';
export class CRBrowser extends BrowserBase { export class CRBrowser extends BrowserBase {
readonly _connection: CRConnection; readonly _connection: CRConnection;

2
src/firefox/ffBrowser.ts
View file

@ -27,7 +27,7 @@ import { ConnectionEvents, FFConnection } from './ffConnection';
import { headersArray } from './ffNetworkManager'; import { headersArray } from './ffNetworkManager';
import { FFPage } from './ffPage'; import { FFPage } from './ffPage';
import { Protocol } from './protocol'; import { Protocol } from './protocol';
import type { BrowserServer } from '../server/browserServer'; import { BrowserServer } from '../server/browserServer';
export class FFBrowser extends BrowserBase { export class FFBrowser extends BrowserBase {
_connection: FFConnection; _connection: FFConnection;

2
src/webkit/wkBrowser.ts
View file

@ -26,7 +26,7 @@ import * as types from '../types';
import { Protocol } from './protocol'; import { Protocol } from './protocol';
import { kPageProxyMessageReceived, PageProxyMessageReceivedPayload, WKConnection, WKSession } from './wkConnection'; import { kPageProxyMessageReceived, PageProxyMessageReceivedPayload, WKConnection, WKSession } from './wkConnection';
import { WKPage } from './wkPage'; import { WKPage } from './wkPage';
import type { BrowserServer } from '../server/browserServer'; import { BrowserServer } from '../server/browserServer';
const DEFAULT_USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.4 Safari/605.1.15'; const DEFAULT_USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.4 Safari/605.1.15';

11
utils/doclint/check_public_api/JSBuilder.js
View file

@ -107,17 +107,6 @@ function checkSources(sources) {
} }
if (fileName.endsWith('/api.ts') && ts.isExportSpecifier(node)) if (fileName.endsWith('/api.ts') && ts.isExportSpecifier(node))
apiClassNames.add(expandPrefix((node.propertyName || node.name).text)); apiClassNames.add(expandPrefix((node.propertyName || node.name).text));
if (!fileName.includes('src/server/')) {
// Only relative imports.
if (ts.isImportDeclaration(node) && ts.isStringLiteral(node.moduleSpecifier)) {
const module = node.moduleSpecifier.text;
const isServerDependency = path.resolve(path.dirname(fileName), module).includes('src/server');
if (isServerDependency && !node.importClause.isTypeOnly) {
const lac = ts.getLineAndCharacterOfPosition(node.getSourceFile(), node.moduleSpecifier.pos);
errors.push(`Disallowed import "${module}" at ${node.getSourceFile().fileName}:${lac.line + 1}`);
}
}
}
ts.forEachChild(node, visit); ts.forEachChild(node, visit);
} }