infra(channel): add edge stable bot (#5825)

.github/workflows/tests.yml

@@ -294,3 +294,32 @@ jobs:
       with:
         name: chrome-stable-test-results
         path: test-results
+
+  edge_stable:
+    name: "Edge Stable (Win)"
+    runs-on: windows-latest
+    steps:
+    - name: Install Media Pack
+      shell: powershell
+      run: Install-WindowsFeature Server-Media-Foundation
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v1
+      with:
+        node-version: 10
+    - run: npm ci
+      env:
+        PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+    - run: npm run build
+    # This only created problems, should we move ffmpeg back into npm?
+    - run: node lib/cli/cli install ffmpeg
+    - run: npx folio test/ --workers=1 --forbid-only --global-timeout=5400000 --retries=3 --reporter=dot,json
+      shell: bash
+      env:
+        BROWSER: "chromium"
+        PW_CHROMIUM_CHANNEL: "msedge"
+        FOLIO_JSON_OUTPUT_NAME: "test-results/report.json"
+    - uses: actions/upload-artifact@v1
+      if: ${{ always() }}
+      with:
+        name: edge-stable-test-results
+        path: test-results

src/server/browserType.ts

@@ -178,7 +178,7 @@ export abstract class BrowserType extends SdkObject {
     }
 
     if (!executable) {
-      // We can only validate dependencies for bundled browsers.
+      // Only validate dependencies for bundled browsers.
       await validateHostRequirements(this._registry, this._name);
     }
 

test/downloads-path.spec.ts

@@ -50,7 +50,6 @@ fixtures.persistentDownloadsContext.init(async ({ server, launchPersistent, test
       {
         downloadsPath: testInfo.outputPath(''),
         acceptDownloads: true,
-        channel: browserChannel,
       }
   );
   logOnCI('--- setting content for the page ---');