Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(trace-viewer): restore dragndrop (#9697)

Browse source
This commit is contained in:
Pavel Feldman 2021-10-21 21:06:24 -08:00 committed by GitHub
parent e7b4c181c7
commit ea7a294924
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/trace/viewer/traceViewer.ts
View file

@ -77,6 +77,6 @@ export async function showTraceViewer(traceUrl: string, browserName: string, hea
else else
page.on('close', () => process.exit()); page.on('close', () => process.exit());
await page.mainFrame().goto(internalCallMetadata(), urlPrefix + `/trace/index.html?trace=${traceUrl}`); await page.mainFrame().goto(internalCallMetadata(), urlPrefix + `/trace/index.html${traceUrl ? '?trace=' + traceUrl : ''}`);
return context; return context;
} }

10
packages/playwright-core/src/web/traceViewer/ui/workbench.tsx
View file

@ -62,8 +62,14 @@ export const Workbench: React.FunctionComponent<{
onDragOver={event => { event.preventDefault(); }} onDragOver={event => { event.preventDefault(); }}
onDrop={event => { onDrop={event => {
event.preventDefault(); event.preventDefault();
const url = URL.createObjectURL(event.dataTransfer.files[0]); const blobTraceURL = URL.createObjectURL(event.dataTransfer.files[0]);
setTraceURL(url.toString()); const url = new URL(window.location.href);
url.searchParams.set('trace', blobTraceURL);
const href = url.toString();
// Snapshot loaders will inherit the trace url from the query parameters,
// so set it here.
window.history.pushState({}, '', href);
setTraceURL(blobTraceURL);
}}> }}>
<div className='hbox header'> <div className='hbox header'>
<div className='logo'>🎭</div> <div className='logo'>🎭</div>