From eba86fcc537129975db371a677f75c74be71c13a Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Mon, 27 Feb 2023 15:49:25 -0500 Subject: [PATCH] fix(doc): electron evaluate evaluates in electron not worker (#20892) --- docs/src/api/params.md | 2 +- packages/playwright-core/types/types.d.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/api/params.md b/docs/src/api/params.md index 22155e2022..48571a4b62 100644 --- a/docs/src/api/params.md +++ b/docs/src/api/params.md @@ -450,7 +450,7 @@ Function to be evaluated in the worker context. * langs: js - `pageFunction` <[function]|[Electron]> -Function to be evaluated in the worker context. +Function to be evaluated in the main Electron process. ## python-context-option-viewport * langs: python diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts index 216d82687f..11b5c56352 100644 --- a/packages/playwright-core/types/types.d.ts +++ b/packages/playwright-core/types/types.d.ts @@ -12942,7 +12942,7 @@ export interface ElectronApplication { * [electronApplication.evaluate(pageFunction[, arg])](https://playwright.dev/docs/api/class-electronapplication#electron-application-evaluate) * returns `undefined`. Playwright also supports transferring some additional values that are not serializable by * `JSON`: `-0`, `NaN`, `Infinity`, `-Infinity`. - * @param pageFunction Function to be evaluated in the worker context. + * @param pageFunction Function to be evaluated in the main Electron process. * @param arg Optional argument to pass to `pageFunction`. */ evaluate(pageFunction: PageFunctionOn, arg: Arg): Promise; @@ -12961,7 +12961,7 @@ export interface ElectronApplication { * [electronApplication.evaluate(pageFunction[, arg])](https://playwright.dev/docs/api/class-electronapplication#electron-application-evaluate) * returns `undefined`. Playwright also supports transferring some additional values that are not serializable by * `JSON`: `-0`, `NaN`, `Infinity`, `-Infinity`. - * @param pageFunction Function to be evaluated in the worker context. + * @param pageFunction Function to be evaluated in the main Electron process. * @param arg Optional argument to pass to `pageFunction`. */ evaluate(pageFunction: PageFunctionOn, arg?: any): Promise; @@ -12982,7 +12982,7 @@ export interface ElectronApplication { * returns a [Promise], then * [electronApplication.evaluateHandle(pageFunction[, arg])](https://playwright.dev/docs/api/class-electronapplication#electron-application-evaluate-handle) * would wait for the promise to resolve and return its value. - * @param pageFunction Function to be evaluated in the worker context. + * @param pageFunction Function to be evaluated in the main Electron process. * @param arg Optional argument to pass to `pageFunction`. */ evaluateHandle(pageFunction: PageFunctionOn, arg: Arg): Promise>; @@ -13002,7 +13002,7 @@ export interface ElectronApplication { * returns a [Promise], then * [electronApplication.evaluateHandle(pageFunction[, arg])](https://playwright.dev/docs/api/class-electronapplication#electron-application-evaluate-handle) * would wait for the promise to resolve and return its value. - * @param pageFunction Function to be evaluated in the worker context. + * @param pageFunction Function to be evaluated in the main Electron process. * @param arg Optional argument to pass to `pageFunction`. */ evaluateHandle(pageFunction: PageFunctionOn, arg?: any): Promise>;