Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(test-runner): more default workers for M1 (#12660)

Browse source 
New default is based on the very (unscientific) output of repeated a few
times:

```
$ for i in `seq 5 13`; do time npm run ctest -- --reporter=line --workers=$i 'page/*' 'selector*' 'channels*' 'resource-timing*'; done
```
This commit is contained in:
Ross Wollman 2022-03-11 02:12:07 -08:00 committed by GitHub
parent 1dc581c1a0
commit ebae5e76df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-test/src/cli.ts
View file

@ -20,6 +20,7 @@ import { Command } from 'commander';
import fs from 'fs'; import fs from 'fs';
import url from 'url'; import url from 'url';
import path from 'path'; import path from 'path';
import os from 'os';
import type { Config } from './types'; import type { Config } from './types';
import { Runner, builtInReporters, BuiltInReporter, kDefaultConfigFiles } from './runner'; import { Runner, builtInReporters, BuiltInReporter, kDefaultConfigFiles } from './runner';
import { stopProfiling, startProfiling } from './profiler'; import { stopProfiling, startProfiling } from './profiler';
@ -27,7 +28,7 @@ import { FilePatternFilter } from './util';
import { showHTMLReport } from './reporters/html'; import { showHTMLReport } from './reporters/html';
import { GridServer } from 'playwright-core/lib/grid/gridServer'; import { GridServer } from 'playwright-core/lib/grid/gridServer';
import dockerFactory from 'playwright-core/lib/grid/dockerGridFactory'; import dockerFactory from 'playwright-core/lib/grid/dockerGridFactory';
import { createGuid } from 'playwright-core/lib/utils/utils'; import { createGuid, hostPlatform } from 'playwright-core/lib/utils/utils';
import { fileIsModule } from './loader'; import { fileIsModule } from './loader';
const defaultTimeout = 30000; const defaultTimeout = 30000;
@ -107,13 +108,16 @@ Examples:
async function runTests(args: string[], opts: { [key: string]: any }) { async function runTests(args: string[], opts: { [key: string]: any }) {
await startProfiling(); await startProfiling();
const cpus = os.cpus().length;
const workers = hostPlatform.startsWith('mac') && hostPlatform.endsWith('arm64') ? cpus : Math.ceil(cpus / 2);
const defaultConfig: Config = { const defaultConfig: Config = {
preserveOutput: 'always', preserveOutput: 'always',
reporter: [ [defaultReporter] ], reporter: [ [defaultReporter] ],
reportSlowTests: { max: 5, threshold: 15000 }, reportSlowTests: { max: 5, threshold: 15000 },
timeout: defaultTimeout, timeout: defaultTimeout,
updateSnapshots: 'missing', updateSnapshots: 'missing',
workers: Math.ceil(require('os').cpus().length / 2), workers,
}; };
if (opts.browser) { if (opts.browser) {