From ebb4c3320f113695c84c4a24d640781a2387f41b Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 10 Jul 2020 16:15:12 -0700 Subject: [PATCH] test: mark 2 chromium not important win tests as failed (#2914) --- test/chromium/launcher.spec.js | 2 +- test/launcher.spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/chromium/launcher.spec.js b/test/chromium/launcher.spec.js index 8d51b92cd7..4d97969536 100644 --- a/test/chromium/launcher.spec.js +++ b/test/chromium/launcher.spec.js @@ -32,7 +32,7 @@ describe('launcher', function() { const browser = await browserType.launchServer(options); await browser.close(); }); - it.skip(USES_HOOKS)('should open devtools when "devtools: true" option is given', async({browserType, defaultBrowserOptions}) => { + it.skip(USES_HOOKS).fail(CHROMIUM && WIN)('should open devtools when "devtools: true" option is given', async({browserType, defaultBrowserOptions}) => { let devtoolsCallback; const devtoolsPromise = new Promise(f => devtoolsCallback = f); const __testHookForDevTools = devtools => devtools.__testHookOnBinding = parsed => { diff --git a/test/launcher.spec.js b/test/launcher.spec.js index e2f612faa7..f09c8da53f 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -299,7 +299,7 @@ describe('browserType.connect', function() { await browserServer._checkLeaks(); await browserServer.close(); }); - it.skip(USES_HOOKS).slow()('should handle exceptions during connect', async({browserType, defaultBrowserOptions, server}) => { + it.skip(USES_HOOKS).slow().fail(CHROMIUM && WIN)('should handle exceptions during connect', async({browserType, defaultBrowserOptions, server}) => { const browserServer = await browserType.launchServer(defaultBrowserOptions); const __testHookBeforeCreateBrowser = () => { throw new Error('Dummy') }; const error = await browserType.connect({ wsEndpoint: browserServer.wsEndpoint(), __testHookBeforeCreateBrowser }).catch(e => e);