Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: installer compilation (#5908)

Browse source 
For some reason typescript can't find electron types when using
nested tsconfig - workaround the bug.

Drive-by: surface installer compilation problems.
This commit is contained in:
Andrey Lushnikov 2021-03-22 17:39:03 -07:00 committed by GitHub
parent 172de4082a
commit ec6453d1b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
install-from-github.js
View file

@ -21,8 +21,11 @@ const {execSync} = require('child_process');
console.log(`Rebuilding installer...`); console.log(`Rebuilding installer...`);
try { try {
execSync('npm run tsc-installer'); execSync('npm run tsc-installer', {
stdio: ['inherit', 'inherit', 'inherit'],
});
} catch (e) { } catch (e) {
process.exit(1);
} }
console.log(`Downloading browsers...`); console.log(`Downloading browsers...`);

2
src/utils/utils.ts
View file

@ -27,7 +27,7 @@ export function makeWaitForNextTask() {
// As of Mar 2021, Electorn v12 doesn't create new task with `setImmediate` despite // As of Mar 2021, Electorn v12 doesn't create new task with `setImmediate` despite
// using Node 14 internally, so we fallback to `setTimeout(0)` instead. // using Node 14 internally, so we fallback to `setTimeout(0)` instead.
// @see https://github.com/electron/electron/issues/28261 // @see https://github.com/electron/electron/issues/28261
if (process.versions.electron) if ((process.versions as any).electron)
return (callback: () => void) => setTimeout(callback, 0); return (callback: () => void) => setTimeout(callback, 0);
if (parseInt(process.versions.node, 10) >= 11) if (parseInt(process.versions.node, 10) >= 11)
return setImmediate; return setImmediate;