Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(junit reporter): put stdio under testcase (#8900)

Browse source 
When output happened during test execution, it should be
under `<testcase><system-out>...</system-out></testcase>`.
This commit is contained in:
Dmitry Gozman 2021-09-13 17:50:08 -07:00 committed by GitHub
parent 440651e05c
commit ed34a67d4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/test/reporters/junit.ts
View file

@ -147,7 +147,7 @@ class JUnitReporter implements Reporter {
} }
for (const result of test.results) { for (const result of test.results) {
for (const stdout of result.stdout) { for (const stdout of result.stdout) {
entries.push({ entry.children.push({
name: 'system-out', name: 'system-out',
text: stdout.toString() text: stdout.toString()
}); });
@ -155,7 +155,7 @@ class JUnitReporter implements Reporter {
for (const attachment of result.attachments) { for (const attachment of result.attachments) {
if (attachment.path) { if (attachment.path) {
entries.push({ entry.children.push({
name: 'system-out', name: 'system-out',
text: `[[ATTACHMENT|${path.relative(this.config.rootDir, attachment.path)}]]` text: `[[ATTACHMENT|${path.relative(this.config.rootDir, attachment.path)}]]`
}); });
@ -163,7 +163,7 @@ class JUnitReporter implements Reporter {
} }
for (const stderr of result.stderr) { for (const stderr of result.stderr) {
entries.push({ entry.children.push({
name: 'system-err', name: 'system-err',
text: stderr.toString() text: stderr.toString()
}); });

22
tests/playwright-test/junit-reporter.spec.ts
View file

@ -108,11 +108,11 @@ test('should render stdout', async ({ runInlineTest }) => {
`, `,
}, { reporter: 'junit' }); }, { reporter: 'junit' });
const xml = parseXML(result.output); const xml = parseXML(result.output);
const suite = xml['testsuites']['testsuite'][0]; const testcase = xml['testsuites']['testsuite'][0]['testcase'][0];
expect(suite['system-out'].length).toBe(1); expect(testcase['system-out'].length).toBe(1);
expect(suite['system-out'][0]).toContain('Hello world'); expect(testcase['system-out'][0]).toContain('Hello world');
expect(suite['system-out'][0]).not.toContain('u00'); expect(testcase['system-out'][0]).not.toContain('u00');
expect(suite['testcase'][0]['failure'][0]['_']).toContain(`> 9 | test.expect("abc").toBe('abcd');`); expect(testcase['failure'][0]['_']).toContain(`> 9 | test.expect("abc").toBe('abcd');`);
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
}); });
@ -132,9 +132,9 @@ test('should render stdout without ansi escapes', async ({ runInlineTest }) => {
`, `,
}, { reporter: '' }); }, { reporter: '' });
const xml = parseXML(result.output); const xml = parseXML(result.output);
const suite = xml['testsuites']['testsuite'][0]; const testcase = xml['testsuites']['testsuite'][0]['testcase'][0];
expect(suite['system-out'].length).toBe(1); expect(testcase['system-out'].length).toBe(1);
expect(suite['system-out'][0].trim()).toBe('Hello world'); expect(testcase['system-out'][0].trim()).toBe('Hello world');
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
}); });
@ -232,9 +232,9 @@ test('should render attachments', async ({ runInlineTest }) => {
`, `,
}, { reporter: 'junit' }); }, { reporter: 'junit' });
const xml = parseXML(result.output); const xml = parseXML(result.output);
const suite = xml['testsuites']['testsuite'][0]; const testcase = xml['testsuites']['testsuite'][0]['testcase'][0];
expect(suite['system-out'].length).toBe(1); expect(testcase['system-out'].length).toBe(1);
expect(suite['system-out'][0].trim()).toBe(`[[ATTACHMENT|test-results${path.sep}a-one${path.sep}test-finished-1.png]]`); expect(testcase['system-out'][0].trim()).toBe(`[[ATTACHMENT|test-results${path.sep}a-one${path.sep}test-finished-1.png]]`);
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
}); });