From edc052b863ef6ea41f493e89eb51fc8827e758c1 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 22 Oct 2024 12:53:56 +0200 Subject: [PATCH] fix --- packages/trace-viewer/src/sw/snapshotRenderer.ts | 2 +- tests/library/trace-viewer.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/trace-viewer/src/sw/snapshotRenderer.ts b/packages/trace-viewer/src/sw/snapshotRenderer.ts index 6fa91d472b..438683ed84 100644 --- a/packages/trace-viewer/src/sw/snapshotRenderer.ts +++ b/packages/trace-viewer/src/sw/snapshotRenderer.ts @@ -439,7 +439,7 @@ function snapshotScript(...targetIds: (string | undefined)[]) { } - if (isTopFrame) { + if (!isTopFrame) { for (const canvas of canvasElements) { const context = canvas.getContext('2d')!; drawCheckerboard(context, canvas); diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts index 88fe277829..3af4feaeb5 100644 --- a/tests/library/trace-viewer.spec.ts +++ b/tests/library/trace-viewer.spec.ts @@ -1461,7 +1461,7 @@ test('canvas clipping in iframe', async ({ runAndTrace, page, server }) => { await rafraf(page, 5); }); - const snapshot = await traceViewer.snapshotFrame('page.waitForTimeout'); + const snapshot = await traceViewer.snapshotFrame('page.evaluate'); const canvas = snapshot.locator('iframe').contentFrame().locator('canvas'); await expect(canvas).toHaveAttribute('title', `Playwright displays canvas contents on a best-effort basis. It doesn't support canvas elements inside an iframe yet. If this impacts your workflow, please open an issue so we can prioritize.`); });